From: Shuah Khan <shuah.kh@samsung.com>
To: akpm@linux-foundation.org, alexander.h.duyck@intel.com,
dan.carpenter@oracle.com
Cc: Shuah Khan <shuah.kh@samsung.com>,
linux-kernel@vger.kernel.org, shuahkhan@gmail.com
Subject: [PATCH linux-next] dma-debug: Fix coccinelle warnings in device_dma_allocations()
Date: Tue, 26 Nov 2013 13:51:15 -0700 [thread overview]
Message-ID: <1385499075-1928-1-git-send-email-shuah.kh@samsung.com> (raw)
lib/dma-debug.c:740:11-16: ERROR: invalid reference to the index variable of the iterator on line 726
This error is a result of referencing entry->dev in dev_warn() when entry
might not be valid at the time of reference. Change dev_warn() to use input
parameter struct device *dev instead to print warning.
Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
lib/dma-debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index e34865e..5f29445 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -737,7 +737,7 @@ static int device_dma_allocations(struct device *dev, struct dma_debug_entry **o
local_irq_restore(flags);
if (map_err_cnt)
- dev_warn(entry->dev,
+ dev_warn(dev,
"DMA-API: device driver failed to check map errors: "
"[count] = %d\n", map_err_cnt);
return count;
--
1.8.3.2
reply other threads:[~2013-11-26 20:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385499075-1928-1-git-send-email-shuah.kh@samsung.com \
--to=shuah.kh@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).