[2/9] ACPI / PCI: Use global PCI rescan-remove locking in PCI root hotplug
diff mbox series

Message ID 3089678.gd7W8nYHSz@vostro.rjw.lan
State New, archived
Headers show
  • PCI: Eliminate race conditions between hotplug and sysfs rescan/remove (Was: Re: [PATCH v2 04/10] PCI: Destroy pci dev only once)
Related show

Commit Message

Rafael J. Wysocki Jan. 10, 2014, 2:23 p.m. UTC
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Multiple race conditions are possible between the addition and
removal of PCI devices during ACPI PCI host bridge hotplug and the
generic PCI bus rescan and device removal that can be triggered via

To avoid those race conditions make the ACPI PCI host bridge addition
and removal code use global PCI rescan-remove locking.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
 drivers/acpi/pci_root.c |    6 ++++++
 1 file changed, 6 insertions(+)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

diff mbox series

Index: linux-pm/drivers/acpi/pci_root.c
--- linux-pm.orig/drivers/acpi/pci_root.c
+++ linux-pm/drivers/acpi/pci_root.c
@@ -604,7 +604,9 @@  static int acpi_pci_root_add(struct acpi
+	pci_lock_rescan_remove();
+	pci_unlock_rescan_remove();
 	return 1;
@@ -616,6 +618,8 @@  static void acpi_pci_root_remove(struct
 	struct acpi_pci_root *root = acpi_driver_data(device);
+	pci_lock_rescan_remove();
 	device_set_run_wake(root->bus->bridge, false);
@@ -623,6 +627,8 @@  static void acpi_pci_root_remove(struct
+	pci_unlock_rescan_remove();