From: Jassi Brar <jassisinghbrar@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, s-anna@ti.com, tony@atomide.com,
omar.ramirez@copitl.com, loic.pallardy@st.com,
lftan.linux@gmail.com, slapdau@yahoo.com.au,
courtney.cavin@sonymobile.com, rafael.j.wysocki@intel.com,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: [PATCHv3 5/6] mailbox: Fix deleteing poll timer
Date: Sat, 15 Feb 2014 23:56:41 +0530 [thread overview]
Message-ID: <1392488801-18133-1-git-send-email-jaswinder.singh@linaro.org> (raw)
In-Reply-To: <1392488526-17715-1-git-send-email-jaswinder.singh@linaro.org>
From: LeyFoon Tan <lftan.linux@gmail.com>
Try to delete the timer only if it was init/used.
Signed-off-by: LeyFoon Tan <lftan.linux@gmail.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---
drivers/mailbox/mailbox.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
index f8b31da..bac767e 100644
--- a/drivers/mailbox/mailbox.c
+++ b/drivers/mailbox/mailbox.c
@@ -529,7 +529,8 @@ void ipc_links_unregister(struct ipc_controller *ipc)
list_for_each_entry(chan, &con->channels, node)
ipc_free_channel((void *)chan);
- del_timer_sync(&con->poll);
+ if (ipc->txdone_poll)
+ del_timer_sync(&con->poll);
kfree(con);
}
--
1.8.1.2
next prev parent reply other threads:[~2014-02-15 18:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 18:22 [PATCHv3] Generic Mailbox API Jassi Brar
2014-02-15 18:24 ` [PATCHv3 1/6] mailbox: rename pl320-ipc specific mailbox.h Jassi Brar
2014-02-15 18:25 ` [PATCHv3 2/6] mailbox: Introduce a new common API Jassi Brar
2014-02-15 19:03 ` Greg KH
2014-02-15 19:04 ` Greg KH
2014-02-15 19:05 ` Greg KH
2014-02-15 19:15 ` Greg KH
2014-02-16 6:36 ` Jassi Brar
2014-02-16 16:36 ` Greg KH
2014-02-18 0:52 ` Courtney Cavin
2014-02-18 7:06 ` Jassi Brar
2014-02-18 17:30 ` Bjorn Andersson
2014-02-18 18:33 ` Jassi Brar
2014-02-18 19:47 ` Courtney Cavin
2014-02-19 21:43 ` Jassi Brar
2014-02-18 21:32 ` Kumar Gala
2014-02-19 10:53 ` Jassi Brar
2014-02-15 18:25 ` [PATCHv3 3/6] mailbox: pl320: Introduce common API driver Jassi Brar
2014-02-15 18:26 ` [PATCHv3 4/6] mailbox: Fix TX completion init Jassi Brar
2014-02-15 18:26 ` Jassi Brar [this message]
2014-02-15 18:27 ` [PATCHv3 6/6] mailbox: move the internal definitions into a private file Jassi Brar
2014-02-15 19:15 ` Greg KH
2014-02-15 19:16 ` Greg KH
2014-02-16 6:38 ` Jassi Brar
2014-02-17 5:57 ` [PATCHv3] Generic Mailbox API Craig McGeachie
2014-02-17 6:02 ` Jassi Brar
2014-02-17 6:03 ` Craig McGeachie
2014-02-17 6:12 ` Jassi Brar
2014-03-06 3:55 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392488801-18133-1-git-send-email-jaswinder.singh@linaro.org \
--to=jassisinghbrar@gmail.com \
--cc=courtney.cavin@sonymobile.com \
--cc=gregkh@linuxfoundation.org \
--cc=jaswinder.singh@linaro.org \
--cc=lftan.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=omar.ramirez@copitl.com \
--cc=rafael.j.wysocki@intel.com \
--cc=s-anna@ti.com \
--cc=slapdau@yahoo.com.au \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).