linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jeff V. Merkey" <jmerkey@vger.timpanogas.org>
To: linux-kernel@vger.kernel.org
Cc: jmerkey@timpanogas.org
Subject: [PATCH] kdb/mdb hardware breakpoints broken 2.4.17/18
Date: Wed, 23 Jan 2002 14:00:45 -0700	[thread overview]
Message-ID: <20020123140045.A17976@vger.timpanogas.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]



Please find a patch that corrects the problem with hardware 
breakpoints not working with kdb.  I have noticed that gdb uses 
inserted int3 (0xCC) breakpoints (as does kdb) for soft breakpoint
support, so this fix may not affect these programs.  It is not 
clear why every signal handled is writing a 0 t the DR7 register.

Patch submitted to Keith Owens and Linux kernel.

Jeff


[-- Attachment #2: patch-0123.kdb --]
[-- Type: text/plain, Size: 584 bytes --]

diff -Naur ./arch/i386/kernel/signal.c ../linux-new/./arch/i386/kernel/signal.c
--- ./arch/i386/kernel/signal.c	Fri Sep 14 15:15:40 2001
+++ ../linux-new/./arch/i386/kernel/signal.c	Wed Jan 23 13:26:07 2002
@@ -698,7 +698,9 @@
 		 * have been cleared if the watchpoint triggered
 		 * inside the kernel.
 		 */
-		__asm__("movl %0,%%db7"	: : "r" (current->thread.debugreg[7]));
+
+		if (current->thread.debugreg[7])
+		   __asm__("movl %0,%%db7"	: : "r" (current->thread.debugreg[7]));
 
 		/* Whee!  Actually deliver the signal.  */
 		handle_signal(signr, ka, &info, oldset, regs);

             reply	other threads:[~2002-01-23 20:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-23 21:00 Jeff V. Merkey [this message]
     [not found] ` <200201240422.g0O4MuJ26799@bharata.in.ibm.com>
2002-01-24  5:20   ` [PATCH] kdb/mdb hardware breakpoints broken 2.4.17/18 Bharata B Rao
2002-01-24  5:59 ` Keith Owens
2002-01-24 18:15   ` Suparna Bhattacharya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020123140045.A17976@vger.timpanogas.org \
    --to=jmerkey@vger.timpanogas.org \
    --cc=jmerkey@timpanogas.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).