From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Jörg Otte" <jrg.otte@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
"Aubrey Li" <aubrey.li@intel.com>
Subject: [PATCH] Revert "ACPI / sleep: pm_power_off needs more sanity checks to be installed"
Date: Sun, 09 Mar 2014 18:30:50 +0100 [thread overview]
Message-ID: <2617726.ByJ3yc2hCY@vostro.rjw.lan> (raw)
In-Reply-To: <4824481.V0Gqxh5Nec@vostro.rjw.lan>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Revert commit 3130497f5bab (ACPI / sleep: pm_power_off needs more
sanity checks to be installed) that breaks power ACPI power off on a
lot of systems, because it checks wrong registers.
Fixes: 3130497f5bab (ACPI / sleep: pm_power_off needs more sanity checks to be installed)
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
Hi Linus,
Can you take this for 3.14-rc6 directly so that the breakage is not present
in that -rc, please?
I obviously trusted the author of commit 3130497f5bab too much which I shouldn't
have done. My bad and sorry about this mess.
Rafael
---
drivers/acpi/sleep.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
Index: linux-pm/drivers/acpi/sleep.c
===================================================================
--- linux-pm.orig/drivers/acpi/sleep.c
+++ linux-pm/drivers/acpi/sleep.c
@@ -807,12 +807,7 @@ int __init acpi_sleep_init(void)
acpi_sleep_hibernate_setup();
status = acpi_get_sleep_type_data(ACPI_STATE_S5, &type_a, &type_b);
- /*
- * Check both ACPI S5 object and ACPI sleep registers to
- * install pm_power_off_prepare/pm_power_off hook
- */
- if (ACPI_SUCCESS(status) && acpi_gbl_FADT.sleep_control.address
- && acpi_gbl_FADT.sleep_status.address) {
+ if (ACPI_SUCCESS(status)) {
sleep_states[ACPI_STATE_S5] = 1;
pm_power_off_prepare = acpi_power_off_prepare;
pm_power_off = acpi_power_off;
next prev parent reply other threads:[~2014-03-09 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 16:12 [regression] linux-3.14.0-rc5-.. kernel does not switch power off Jörg Otte
2014-03-09 16:55 ` Rafael J. Wysocki
2014-03-09 16:58 ` Rafael J. Wysocki
2014-03-09 17:15 ` Rafael J. Wysocki
2014-03-09 17:34 ` Jörg Otte
2014-03-09 17:30 ` Rafael J. Wysocki [this message]
2014-03-09 17:18 ` Jörg Otte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2617726.ByJ3yc2hCY@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=aubrey.li@intel.com \
--cc=jrg.otte@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).