From: Herbert Xu <herbert@gondor.apana.org.au>
To: Reuben Farrelly <reuben-lkml@reub.net>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, acme@conectiva.com.br,
davem@davemloft.net, greearb@candelatech.com
Subject: [1/3] [NEIGH] Print stack trace in neigh_add_timer
Date: Sun, 23 Oct 2005 17:31:12 +1000 [thread overview]
Message-ID: <20051023073112.GA17626@gondor.apana.org.au> (raw)
In-Reply-To: <E1ETaJB-0004a0-00@gondolin.me.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
[NEIGH] Print stack trace in neigh_add_timer
Stack traces are very helpful in determining the exact nature of a bug.
So let's print a stack trace when the timer is added twice.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p1.patch --]
[-- Type: text/plain, Size: 326 bytes --]
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -732,6 +732,7 @@ static inline void neigh_add_timer(struc
if (unlikely(mod_timer(&n->timer, when))) {
printk("NEIGH: BUG, double timer add, state is %x\n",
n->nud_state);
+ dump_stack();
}
}
next prev parent reply other threads:[~2005-10-23 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.h4unqgj.l34e31@ifi.uio.no>
2005-10-17 6:19 ` 2.6.14-rc4-mm1 Reuben Farrelly
2005-10-23 7:30 ` [0/3] Fix timer bugs in neighbour cache Herbert Xu
2005-10-23 7:31 ` Herbert Xu [this message]
2005-10-23 7:32 ` [2/3] [NEIGH] Fix add_timer race in neigh_add_timer Herbert Xu
2005-10-23 7:33 ` [3/3] [NEIGH] Fix timer leak in neigh_changeaddr Herbert Xu
2005-10-23 18:00 ` Ben Greear
2005-10-23 16:16 ` [0/3] Fix timer bugs in neighbour cache Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051023073112.GA17626@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=acme@conectiva.com.br \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=reuben-lkml@reub.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).