From: George Anzinger <george@mvista.com>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
robustmutexes@lists.osdl.org
Subject: [PATCH] 2.6.14-rc5 fails to build with out CONFIG_FUTEX
Date: Mon, 24 Oct 2005 16:33:36 -0700 [thread overview]
Message-ID: <435D6F50.1000403@mvista.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
Both kernel/exit.c and fs/dcache.c refer to functions in kernel/futex.c which is not built unless
CONFIG_FUTEX is true. This causes a build failure at link time:
LD vmlinux
kernel/built-in.o(.text+0xab58): In function `do_exit':
/usr/src/linux-2.6.14-rc/kernel/exit.c:851: undefined reference to `exit_futex'
fs/built-in.o(.text+0x1b2bf): In function `dput':
/usr/src/linux-2.6.14-rc/fs/dcache.c:165: undefined reference to `futex_free_robust_list'
Attached patch "defines" away the problem.
--
George Anzinger george@mvista.com
HRT (High-res-timers): http://sourceforge.net/projects/high-res-timers/
[-- Attachment #2: futux-fix.patch --]
[-- Type: text/plain, Size: 1061 bytes --]
Source: MontaVista Software, Inc.
Type: Defect Fix
Description:
CONFIG_FUTEX is an option but kernel/exit.c and fs/dcache.c refer to functions in kernel/futux.c unconditionally. This patch ties those request off and allows a build with CONFIG_FUTEX "not set".
Signed-off-by: George Anzinger <george@mvista.com>
include/linux/futex.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletion(-)
Index: linux-2.6.14-rc/include/linux/futex.h
===================================================================
--- linux-2.6.14-rc.orig/include/linux/futex.h
+++ linux-2.6.14-rc/include/linux/futex.h
@@ -35,9 +35,13 @@
long do_futex(unsigned long uaddr, int op, int val,
unsigned long timeout, unsigned long uaddr2, int val2,
int val3);
-
+#ifdef CONFIG_FUTEX
extern void futex_free_robust_list(struct inode *inode);
extern void exit_futex(struct task_struct *tsk);
+#else
+#define futex_free_robust_list(a)
+#define exit_futex(b)
+#endif
static inline void futex_init_inode(struct inode *inode)
{
INIT_LIST_HEAD(&inode->i_data.robust_list);
next reply other threads:[~2005-10-24 23:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 23:33 George Anzinger [this message]
2005-10-24 23:54 ` [PATCH] 2.6.14-rc5 fails to build with out CONFIG_FUTEX Andrew Morton
2005-10-25 0:38 ` George Anzinger
2005-10-25 0:50 ` Andrew Morton
2005-10-25 5:11 ` George Anzinger
2005-10-25 10:34 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435D6F50.1000403@mvista.com \
--to=george@mvista.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robustmutexes@lists.osdl.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).