From: Sebastian Reichel <sre@kernel.org>
To: Sebastian Reichel <sre@ring0.de>,
Linus Walleij <linus.walleij@linaro.org>,
Shubhrajyoti Datta <omaplinuxkernel@gmail.com>,
Carlos Chinea <cch.devel@gmail.com>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Kumar Gala" <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>,
"Ивайло Димитров" <freemangordon@abv.bg>,
"Joni Lapilainen" <joni.lapilainen@gmail.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Pavel Machek" <pavel@ucw.cz>,
"Sebastian Reichel" <sre@kernel.org>
Subject: [PATCHv4 03/13] HSI: hsi-char: fix driver for multiport scenarios
Date: Fri, 25 Apr 2014 21:06:06 +0200 [thread overview]
Message-ID: <1398452776-28638-4-git-send-email-sre@kernel.org> (raw)
In-Reply-To: <1398452776-28638-1-git-send-email-sre@kernel.org>
Fix return code check of alloc_chrdev_region, which
returns 0 on success.
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
---
drivers/hsi/clients/hsi_char.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
index e61e5f9..3073320 100644
--- a/drivers/hsi/clients/hsi_char.c
+++ b/drivers/hsi/clients/hsi_char.c
@@ -705,7 +705,7 @@ static int hsc_probe(struct device *dev)
if (!hsc_major) {
ret = alloc_chrdev_region(&hsc_dev, hsc_baseminor,
HSC_DEVS, devname);
- if (ret > 0)
+ if (ret == 0)
hsc_major = MAJOR(hsc_dev);
} else {
hsc_dev = MKDEV(hsc_major, hsc_baseminor);
--
1.9.2
next prev parent reply other threads:[~2014-04-25 19:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 19:06 [PATCHv4 00/13] OMAP SSI driver / N900 modem support Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 01/13] Documentation: HSI: Add some general description for the HSI subsystem Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 02/13] MAINTAINERS: update HSI entry Sebastian Reichel
2014-04-25 19:06 ` Sebastian Reichel [this message]
2014-04-25 19:06 ` [PATCHv4 04/13] HSI: method to unregister clients from an hsi port Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 05/13] HSI: Add channel resource support to HSI clients Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 06/13] HSI: export method to (un)register clients Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 07/13] HSI: Add common DT binding for HSI client devices Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 08/13] HSI: Introduce OMAP SSI driver Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 09/13] Documentation: DT: omap-ssi binding documentation Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 10/13] HSI: Introduce driver for SSI Protocol Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 11/13] HSI: Introduce Nokia N900 modem driver Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 12/13] DTS: ARM: OMAP3-N900: Add SSI support Sebastian Reichel
2014-04-25 19:06 ` [PATCHv4 13/13] DTS: ARM: OMAP3-N900: Add modem support Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398452776-28638-4-git-send-email-sre@kernel.org \
--to=sre@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=cch.devel@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=freemangordon@abv.bg \
--cc=galak@codeaurora.org \
--cc=joni.lapilainen@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=omaplinuxkernel@gmail.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).