Compile error in drivers/ide/osb4.c in 240-t10p6

Message ID 20001029144822.B622@jaquet.dk
State New, archived
Headers show
Series
  • Compile error in drivers/ide/osb4.c in 240-t10p6
Related show

Commit Message

Rasmus Andersen Oct. 29, 2000, 1:48 p.m. UTC
<ugh> Forgot to cc linux-kernel

Hi.

I get the following error when trying to compile 2.4.0-test10pre6
without procfs support:

drivers/ide/osb4.c: In function `pci_init_osb4':
drivers/ide/osb4.c:264: `osb4_revision' undeclared (first use in this function)
drivers/ide/osb4.c:264: (Each undeclared identifier is reported only once
drivers/ide/osb4.c:264: for each function it appears in.)
make: *** [drivers/ide/osb4.o] Error 1

The variable, osb4_revision, is inside a #ifdef CONFIG_PROC_FS block but
I was not able to discern if the line where it is referred should be
#ifdef'ed also. The following patch moves the variable declaration out-
side the #ifdef block, as a blind guess...

Comments

Arjan van de Ven Oct. 29, 2000, 1:22 p.m. UTC | #1
In article <20001029144822.B622@jaquet.dk> you wrote:

> The variable, osb4_revision, is inside a #ifdef CONFIG_PROC_FS block but
> I was not able to discern if the line where it is referred should be
> #ifdef'ed also. The following patch moves the variable declaration out-
> side the #ifdef block, as a blind guess...

This patch, and a lot of others of a similar nature, are in my test10pre6
compile patch at 

http://www.fenrus.demon.nl/t10p6.diff

Greetings,
    Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Patch

--- linux-240-t10p6-clean/drivers/ide/osb4.c	Sun Oct 29 09:51:10 2000
+++ linux/drivers/ide/osb4.c	Sun Oct 29 13:55:23 2000
@@ -56,11 +56,12 @@ 
 
 #define DISPLAY_OSB4_TIMINGS
 
+static byte osb4_revision = 0;
+
 #if defined(DISPLAY_OSB4_TIMINGS) && defined(CONFIG_PROC_FS)
 #include <linux/stat.h>
 #include <linux/proc_fs.h>
 
-static byte osb4_revision = 0;
 static struct pci_dev *bmide_dev;
 
 static int osb4_get_info(char *, char **, off_t, int, int);