From: Peter Feuerer <peter@piie.net>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Feuerer <peter@piie.net>,
Andrew Morton <akpm@linux-foundation.org>,
Zhang Rui <rui.zhang@intel.com>, Andreas Mohr <andi@lisas.de>,
Borislav Petkov <bp@suse.de>, Javi Merino <javi.merino@arm.com>
Subject: [PATCH v3 3/6] thermal: Added Bang-bang thermal governor
Date: Sat, 3 May 2014 19:59:23 +0200 [thread overview]
Message-ID: <1399139966-10625-4-git-send-email-peter@piie.net> (raw)
In-Reply-To: <1399139966-10625-1-git-send-email-peter@piie.net>
The bang-bang thermal governor uses a hysteresis to switch abruptly on
or off a cooling device. It is intended to control fans, which can
not be throttled but just switched on or off.
Bang-bang cannot be set as default governor as it is intended for
special devices only. For those special devices the driver needs to
explicitely request it.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Andreas Mohr <andi@lisas.de>
Cc: Borislav Petkov <bp@suse.de>
Cc: Javi Merino <javi.merino@arm.com>
Signed-off-by: Peter Feuerer <peter@piie.net>
---
drivers/thermal/Kconfig | 10 +++
drivers/thermal/Makefile | 1 +
drivers/thermal/gov_bang_bang.c | 131 ++++++++++++++++++++++++++++++++++++++++
drivers/thermal/thermal_core.c | 5 ++
drivers/thermal/thermal_core.h | 8 +++
5 files changed, 155 insertions(+)
create mode 100644 drivers/thermal/gov_bang_bang.c
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 2d51912..2ede94f 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -84,6 +84,16 @@ config THERMAL_GOV_STEP_WISE
Enable this to manage platform thermals using a simple linear
governor.
+config THERMAL_GOV_BANG_BANG
+ bool "Bang Bang thermal governor"
+ default y
+ help
+ Enable this to manage platform thermals using bang bang governor.
+
+ Say 'Y' here if you want to use two point temperature regulation
+ used for fans without throttling. Some fan drivers depend on this
+ governor to be enabled (e.g. acerhdf).
+
config THERMAL_GOV_USER_SPACE
bool "User_space thermal governor"
help
diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
index 54e4ec9..1c32a5d 100644
--- a/drivers/thermal/Makefile
+++ b/drivers/thermal/Makefile
@@ -11,6 +11,7 @@ thermal_sys-$(CONFIG_THERMAL_OF) += of-thermal.o
# governors
thermal_sys-$(CONFIG_THERMAL_GOV_FAIR_SHARE) += fair_share.o
+thermal_sys-$(CONFIG_THERMAL_GOV_BANG_BANG) += gov_bang_bang.o
thermal_sys-$(CONFIG_THERMAL_GOV_STEP_WISE) += step_wise.o
thermal_sys-$(CONFIG_THERMAL_GOV_USER_SPACE) += user_space.o
diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c
new file mode 100644
index 0000000..228d0a6
--- /dev/null
+++ b/drivers/thermal/gov_bang_bang.c
@@ -0,0 +1,131 @@
+/*
+ * gov_bang_bang.c - A simple thermal throttling governor using hysteresis
+ *
+ * Copyright (C) 2014 Peter Feuerer <peter@piie.net>
+ *
+ * Based on step_wise.c with following Copyrights:
+ * Copyright (C) 2012 Intel Corp
+ * Copyright (C) 2012 Durgadoss R <durgadoss.r@intel.com>
+ *
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, version 2.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
+ * the GNU General Public License for more details.
+ *
+ */
+
+#include <linux/thermal.h>
+
+#include "thermal_core.h"
+
+static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
+{
+ long trip_temp;
+ unsigned long trip_hyst;
+ struct thermal_instance *instance;
+
+ tz->ops->get_trip_temp(tz, trip, &trip_temp);
+ tz->ops->get_trip_hyst(tz, trip, &trip_hyst);
+
+ dev_dbg(&tz->device, "Trip%d[temp=%ld]:temp=%d:hyst=%ld\n",
+ trip, trip_temp, tz->temperature,
+ trip_hyst);
+
+ mutex_lock(&tz->lock);
+
+ list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
+ if (instance->trip != trip)
+ continue;
+
+ /* in case fan is in initial state, switch the fan off */
+ if (instance->target == THERMAL_NO_TARGET)
+ instance->target = 0;
+
+ /* in case fan is neither on nor off set the fan to active */
+ if (instance->target != 0 && instance->target != 1) {
+ pr_warn("Thermal instance %s controlled by bang-bang has unexpected state: %ld\n",
+ instance->name, instance->target);
+ instance->target = 1;
+ }
+
+ /*
+ * enable fan when temperature exceeds trip_temp and disable
+ * the fan in case it falls below trip_temp minus hysteresis
+ */
+ if (instance->target == 0 && tz->temperature >= trip_temp)
+ instance->target = 1;
+ else if (instance->target == 1 &&
+ tz->temperature < trip_temp - trip_hyst)
+ instance->target = 0;
+
+ dev_dbg(&instance->cdev->device, "target=%d\n",
+ (int)instance->target);
+
+ instance->cdev->updated = false; /* cdev needs update */
+ }
+
+ mutex_unlock(&tz->lock);
+}
+
+/**
+ * bang_bang_throttle - controls devices associated with the given zone
+ * @tz - thermal_zone_device
+ * @trip - the trip point
+ *
+ * Regulation Logic: a two point regulation, deliver cooling state depending
+ * on the previous state shown in this diagram:
+ *
+ * Fan: OFF ON
+ *
+ * |
+ * |
+ * trip_temp: +---->+
+ * | | ^
+ * | | |
+ * | | Temperature
+ * (trip_temp - hyst): +<----+
+ * |
+ * |
+ * |
+ *
+ * * If the fan is not running and temperature exceeds trip_temp, the fan
+ * gets turned on.
+ * * In case the fan is running, temperature must fall below
+ * (trip_temp - hyst) so that the fan gets turned off again.
+ *
+ */
+static int bang_bang_throttle(struct thermal_zone_device *tz, int trip)
+{
+ struct thermal_instance *instance;
+
+ thermal_zone_trip_update(tz, trip);
+
+ mutex_lock(&tz->lock);
+
+ list_for_each_entry(instance, &tz->thermal_instances, tz_node)
+ thermal_cdev_update(instance->cdev);
+
+ mutex_unlock(&tz->lock);
+
+ return 0;
+}
+
+static struct thermal_governor thermal_gov_bang_bang = {
+ .name = "bang_bang",
+ .throttle = bang_bang_throttle,
+};
+
+int thermal_gov_bang_bang_register(void)
+{
+ return thermal_register_governor(&thermal_gov_bang_bang);
+}
+
+void thermal_gov_bang_bang_unregister(void)
+{
+ thermal_unregister_governor(&thermal_gov_bang_bang);
+}
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 71b0ec0..4c2726b 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1790,6 +1790,10 @@ static int __init thermal_register_governors(void)
if (result)
return result;
+ result = thermal_gov_bang_bang_register();
+ if (result)
+ return result;
+
return thermal_gov_user_space_register();
}
@@ -1797,6 +1801,7 @@ static void thermal_unregister_governors(void)
{
thermal_gov_step_wise_unregister();
thermal_gov_fair_share_unregister();
+ thermal_gov_bang_bang_unregister();
thermal_gov_user_space_unregister();
}
diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
index 3db339f..d15d243 100644
--- a/drivers/thermal/thermal_core.h
+++ b/drivers/thermal/thermal_core.h
@@ -69,6 +69,14 @@ static inline int thermal_gov_fair_share_register(void) { return 0; }
static inline void thermal_gov_fair_share_unregister(void) {}
#endif /* CONFIG_THERMAL_GOV_FAIR_SHARE */
+#ifdef CONFIG_THERMAL_GOV_BANG_BANG
+int thermal_gov_bang_bang_register(void);
+void thermal_gov_bang_bang_unregister(void);
+#else
+static inline int thermal_gov_bang_bang_register(void) { return 0; }
+static inline void thermal_gov_bang_bang_unregister(void) {}
+#endif /* CONFIG_THERMAL_GOV_BANG_BANG */
+
#ifdef CONFIG_THERMAL_GOV_USER_SPACE
int thermal_gov_user_space_register(void);
void thermal_gov_user_space_unregister(void);
--
1.9.2
next prev parent reply other threads:[~2014-05-03 18:01 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 1:23 [PATCH 0/4] acerhdf/thermal: adding new models and appropriate governor Peter Feuerer
2014-04-27 1:23 ` [PATCH 1/4] acerhdf: Adding support for "manual mode" Peter Feuerer
2014-04-27 21:03 ` Borislav Petkov
2014-04-27 22:22 ` Peter Feuerer
2014-04-27 1:23 ` [PATCH 2/4] acerhdf: Adding support for new models Peter Feuerer
2014-04-27 1:23 ` [PATCH 3/4] thermal: Added Bang-bang thermal governor Peter Feuerer
2014-04-27 1:23 ` [PATCH 4/4] acerhdf: Use bang-bang " Peter Feuerer
2014-04-27 18:57 ` [PATCH 0/4] acerhdf/thermal: adding new models and appropriate governor Andreas Mohr
2014-04-27 23:13 ` Peter Feuerer
2014-04-28 4:58 ` Andreas Mohr
2014-04-29 9:17 ` [PATCH v2 " Peter Feuerer
2014-04-29 9:17 ` [PATCH v2 1/4] acerhdf: Adding support for "manual mode" Peter Feuerer
2014-04-29 9:17 ` [PATCH v2 2/4] acerhdf: Adding support for new models Peter Feuerer
2014-04-29 9:17 ` [PATCH v2 3/4] thermal: Added Bang-bang thermal governor Peter Feuerer
2014-04-29 15:53 ` Javi Merino
2014-04-29 16:37 ` Peter Feuerer
2014-04-29 21:31 ` Peter Feuerer
2014-04-30 9:01 ` Javi Merino
2014-04-29 9:17 ` [PATCH v2 4/4] acerhdf: Use bang-bang " Peter Feuerer
2014-04-29 16:00 ` Javi Merino
2014-04-29 16:43 ` Peter Feuerer
2014-05-01 18:36 ` [PATCH v2 0/4] acerhdf/thermal: adding new models and appropriate governor Peter Feuerer
2014-05-03 17:59 ` [PATCH v3 0/6] acerhdf/thermal: adding new models, appropriate governor and minor clean up Peter Feuerer
2014-05-03 17:59 ` [PATCH v3 1/6] acerhdf: Adding support for "manual mode" Peter Feuerer
2014-07-17 9:44 ` Borislav Petkov
2014-05-03 17:59 ` [PATCH v3 2/6] acerhdf: Adding support for new models Peter Feuerer
2014-07-17 9:46 ` Borislav Petkov
2014-07-18 16:06 ` Peter Feuerer
2014-07-18 16:17 ` Borislav Petkov
2014-07-18 16:25 ` Peter Feuerer
2014-05-03 17:59 ` Peter Feuerer [this message]
2014-07-17 9:58 ` [PATCH v3 3/6] thermal: Added Bang-bang thermal governor Borislav Petkov
2014-07-18 16:24 ` Peter Feuerer
2014-05-03 17:59 ` [PATCH v3 4/6] acerhdf: Use bang-bang " Peter Feuerer
2014-05-06 10:50 ` Javi Merino
2014-05-12 10:27 ` Peter Feuerer
2014-05-12 12:03 ` Javi Merino
2014-05-03 17:59 ` [PATCH v3 5/6] acerhdf: added critical trip point Peter Feuerer
2014-05-03 17:59 ` [PATCH v3 6/6] acerhdf: minor clean up Peter Feuerer
2014-07-17 10:12 ` Borislav Petkov
2014-05-15 16:05 ` [PATCH v3 0/6] acerhdf/thermal: adding new models, appropriate governor and " Eduardo Valentin
2014-05-15 22:53 ` Peter Feuerer
2014-06-15 22:39 ` Felix Deichmann
2014-07-30 13:16 ` Eduardo Valentin
2014-07-16 22:24 ` Borislav Petkov
2014-07-16 22:34 ` Peter Feuerer
2014-07-17 8:46 ` Borislav Petkov
2014-07-20 0:51 ` [PATCH v4 " Peter Feuerer
2014-07-20 0:51 ` [PATCH v4 1/6] acerhdf: Adding support for "manual mode" Peter Feuerer
2014-07-20 8:04 ` Andreas Mohr
2014-07-20 10:42 ` Peter Feuerer
2014-07-20 20:20 ` Andreas Mohr
2014-07-20 0:51 ` [PATCH v4 2/6] acerhdf: Adding support for new models Peter Feuerer
2014-07-20 0:51 ` [PATCH v4 3/6] thermal: Added Bang-bang thermal governor Peter Feuerer
2014-07-21 9:29 ` Borislav Petkov
2014-07-21 9:37 ` Zhang Rui
2014-07-21 9:40 ` Zhang Rui
2014-07-22 14:59 ` Peter Feuerer
2014-07-22 16:09 ` Borislav Petkov
2014-07-20 0:51 ` [PATCH v4 4/6] acerhdf: Use bang-bang " Peter Feuerer
2014-07-21 10:23 ` Borislav Petkov
2014-07-20 0:51 ` [PATCH v4 5/6] acerhdf: added critical trip point Peter Feuerer
2014-07-20 0:51 ` [PATCH v4 6/6] acerhdf: minor clean up Peter Feuerer
2014-07-22 15:37 ` [PATCH v5 0/6] acerhdf/thermal: adding new models, appropriate governor and " Peter Feuerer
2014-07-22 15:37 ` [PATCH v5 1/6] acerhdf: Adding support for "manual mode" Peter Feuerer
2014-07-22 15:37 ` [PATCH v5 2/6] acerhdf: Adding support for new models Peter Feuerer
2014-07-22 15:37 ` [PATCH v5 3/6] thermal: Added Bang-bang thermal governor Peter Feuerer
2014-07-26 14:14 ` Peter Feuerer
2014-07-28 2:26 ` Zhang Rui
2014-10-21 10:29 ` Peter Feuerer
2014-10-28 19:33 ` Peter Feuerer
2014-10-29 9:44 ` Javi Merino
2014-10-29 10:14 ` Peter Feuerer
2014-07-22 15:37 ` [PATCH v5 4/6] acerhdf: Use bang-bang " Peter Feuerer
2014-08-27 7:48 ` Zhang Rui
2014-08-27 8:01 ` Peter Feuerer
2014-08-28 1:17 ` Zhang Rui
2014-08-28 6:05 ` Borislav Petkov
2014-07-22 15:37 ` [PATCH v5 5/6] acerhdf: added critical trip point Peter Feuerer
2014-07-26 14:16 ` Peter Feuerer
2014-07-22 15:37 ` [PATCH v5 6/6] acerhdf: minor clean up Peter Feuerer
2014-11-28 14:20 ` [RESEND PATCH v5 0/5] acerhdf: adding new models, appropriate governor and " Peter Feuerer
2014-11-28 14:20 ` [RESEND PATCH v5 1/5] acerhdf: Adding support for "manual mode" Peter Feuerer
2014-11-28 14:20 ` [RESEND PATCH v5 2/5] acerhdf: Adding support for new models Peter Feuerer
2014-11-28 14:20 ` [RESEND PATCH v5 3/5] acerhdf: Use bang-bang thermal governor Peter Feuerer
2014-12-03 9:04 ` Darren Hart
2014-12-04 7:10 ` Peter Feuerer
2014-12-04 7:21 ` Peter Feuerer
2014-12-04 11:40 ` Darren Hart
2014-12-08 7:45 ` Peter Feuerer
2014-12-04 11:18 ` Darren Hart
2014-11-28 14:20 ` [RESEND PATCH v5 4/5] acerhdf: added critical trip point Peter Feuerer
2014-12-03 9:08 ` Darren Hart
2014-11-28 14:20 ` [RESEND PATCH v5 5/5] acerhdf: minor clean up Peter Feuerer
2014-12-03 21:46 ` [RESEND PATCH v5 0/5] acerhdf: adding new models, appropriate governor and " Peter Feuerer
2014-12-11 4:27 ` Darren Hart
2014-12-11 4:59 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399139966-10625-4-git-send-email-peter@piie.net \
--to=peter@piie.net \
--cc=akpm@linux-foundation.org \
--cc=andi@lisas.de \
--cc=bp@suse.de \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).