linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: kuznet@ms2.inr.ac.ru (Alexey Kuznetsov)
Cc: herbert@gondor.apana.org.au, cfriesen@nortel.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	davem@davemloft.net
Subject: [NETLINK]: Use tgid instead of pid for nlmsg_pid
Date: Tue, 22 Nov 2005 09:16:27 +1100	[thread overview]
Message-ID: <E1EeJxb-0006xG-00@gondolin.me.apana.org.au> (raw)
In-Reply-To: <20051121213549.GA28187@ms2.inr.ac.ru>

Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> wrote:
> 
> I agree, apparently netlink_autobind was missed when sed'ing pid->tgid.
> Of course, it does not matter, but tgid is nicer choice from user's viewpoint.

Great, here is the patch to do just that.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -476,7 +476,7 @@ static int netlink_autobind(struct socke
 	struct hlist_head *head;
 	struct sock *osk;
 	struct hlist_node *node;
-	s32 pid = current->pid;
+	s32 pid = current->tgid;
 	int err;
 	static s32 rover = -4097;
 

  parent reply	other threads:[~2005-11-21 22:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-21 19:32 netlink nlmsg_pid supposed to be pid or tid? Christopher Friesen
2005-11-21 19:46 ` Christopher Friesen
2005-11-21 20:51 ` Herbert Xu
2005-11-21 21:35   ` Alexey Kuznetsov
2005-11-21 21:47     ` Christopher Friesen
2005-11-21 22:15       ` Herbert Xu
2005-11-21 22:51         ` Christopher Friesen
2005-11-22  0:09           ` Herbert Xu
2005-11-21 22:49       ` Alexey Kuznetsov
2005-11-21 23:34         ` Herbert Xu
2005-11-21 22:16     ` Herbert Xu [this message]
2005-11-22 22:43       ` [NETLINK]: Use tgid instead of pid for nlmsg_pid David S. Miller
2005-11-23  0:03         ` Herbert Xu
2005-11-23  6:18           ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1EeJxb-0006xG-00@gondolin.me.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=cfriesen@nortel.com \
    --cc=davem@davemloft.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).