From: Mathias Krause <minipli@googlemail.com>
To: David Airlie <airlied@linux.ie>
Cc: linux-kernel@vger.kernel.org,
Mathias Krause <minipli@googlemail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: [PATCH] agp: remove read/write stubs
Date: Sun, 15 Jun 2014 23:02:45 +0200 [thread overview]
Message-ID: <1402866165-17408-1-git-send-email-minipli@googlemail.com> (raw)
The VFS layer handles those in the very same way, if unset. No need for
additional stubs.
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
---
drivers/char/agp/frontend.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/frontend.c
index b29703324e..09f17eb734 100644
--- a/drivers/char/agp/frontend.c
+++ b/drivers/char/agp/frontend.c
@@ -710,19 +710,6 @@ static int agp_open(struct inode *inode, struct file *file)
return 0;
}
-
-static ssize_t agp_read(struct file *file, char __user *buf,
- size_t count, loff_t * ppos)
-{
- return -EINVAL;
-}
-
-static ssize_t agp_write(struct file *file, const char __user *buf,
- size_t count, loff_t * ppos)
-{
- return -EINVAL;
-}
-
static int agpioc_info_wrap(struct agp_file_private *priv, void __user *arg)
{
struct agp_info userinfo;
@@ -1047,8 +1034,6 @@ static const struct file_operations agp_fops =
{
.owner = THIS_MODULE,
.llseek = no_llseek,
- .read = agp_read,
- .write = agp_write,
.unlocked_ioctl = agp_ioctl,
#ifdef CONFIG_COMPAT
.compat_ioctl = compat_agp_ioctl,
--
1.7.10.4
next reply other threads:[~2014-06-15 21:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 21:02 Mathias Krause [this message]
2014-07-02 6:15 ` [PATCH] agp: remove read/write stubs Mathias Krause
2014-07-08 22:48 ` Dave Airlie
2014-07-09 6:52 ` Mathias Krause
2014-07-22 19:50 ` Mathias Krause
2014-08-01 20:01 ` Mathias Krause
2014-08-02 10:08 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402866165-17408-1-git-send-email-minipli@googlemail.com \
--to=minipli@googlemail.com \
--cc=airlied@linux.ie \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).