From: Stephen Hemminger <shemminger@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Johannes Stezenbach <js@linuxtv.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: [PATCH linux-2.6.15-rc5] sk98lin: rx checksum offset not set
Date: Mon, 5 Dec 2005 11:00:40 -0800 [thread overview]
Message-ID: <20051205110040.47adf428@localhost.localdomain> (raw)
In-Reply-To: <20051204234320.GA7478@linuxtv.org>
The checksum offsets for receive offload were not being set correctly.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Index: linux-2.6/drivers/net/sk98lin/skge.c
===================================================================
--- linux-2.6.orig/drivers/net/sk98lin/skge.c
+++ linux-2.6/drivers/net/sk98lin/skge.c
@@ -818,7 +818,7 @@ uintptr_t VNextDescr; /* the virtual bus
/* set the pointers right */
pDescr->VNextRxd = VNextDescr & 0xffffffffULL;
pDescr->pNextRxd = pNextDescr;
- pDescr->TcpSumStarts = 0;
+ if (!IsTx) pDescr->TcpSumStarts = ETH_HLEN << 16 | ETH_HLEN;
/* advance one step */
pPrevDescr = pDescr;
@@ -2169,7 +2169,7 @@ rx_start:
} /* frame > SK_COPY_TRESHOLD */
#ifdef USE_SK_RX_CHECKSUM
- pMsg->csum = pRxd->TcpSums;
+ pMsg->csum = pRxd->TcpSums & 0xffff;
pMsg->ip_summed = CHECKSUM_HW;
#else
pMsg->ip_summed = CHECKSUM_NONE;
next prev parent reply other threads:[~2005-12-05 19:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-04 6:03 Linux 2.6.15-rc5: off-line for a week Linus Torvalds
2005-12-04 15:34 ` Gene Heskett
2005-12-04 18:50 ` Michael Krufky
2005-12-04 20:47 ` Gene Heskett
2005-12-04 21:14 ` Michael Krufky
2005-12-05 0:16 ` Gene Heskett
2005-12-04 16:56 ` Jesper Juhl
2005-12-04 17:26 ` Michal Piotrowski
2005-12-04 18:35 ` Jesper Juhl
2005-12-04 22:25 ` Andrea Arcangeli
2005-12-04 23:43 ` Linux 2.6.15-rc5: sk98lin broken Johannes Stezenbach
2005-12-05 19:00 ` Stephen Hemminger [this message]
2005-12-05 19:22 ` [PATCH linux-2.6.15-rc5] sk98lin: rx checksum offset not set Johannes Stezenbach
2005-12-05 19:13 ` Linux 2.6.15-rc5: sk98lin broken Bill Davidsen
2005-12-07 21:59 ` Linux 2.6.15-rc5: off-line for a week Rich Walker
2005-12-10 16:27 ` Linux 2.6.15-rc5: multiuser scheduling trouble Helge Hafting
2005-12-12 0:09 ` Linus Torvalds
2005-12-12 6:51 ` Ingo Molnar
2005-12-12 11:18 ` Helge Hafting
2005-12-12 11:30 ` Nix
2005-12-12 12:31 ` Helge Hafting
2005-12-12 10:51 ` Helge Hafting
2005-12-10 21:23 ` Linux 2.6.15-rc5 bad page with fglrx on Radeon X300 Brice Goglin
2005-12-10 21:43 ` Lee Revell
2005-12-11 10:49 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051205110040.47adf428@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=jgarzik@pobox.com \
--cc=js@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).