CONFIG_SERIAL_ACPI and early_serial_setup

Message ID Pine.GSO.4.21.0202081320200.29963-100000@vervain.sonytel.be
State New, archived
Headers show
Series
  • CONFIG_SERIAL_ACPI and early_serial_setup
Related show

Commit Message

Geert Uytterhoeven Feb. 8, 2002, 12:25 p.m. UTC
If CONFIG_SERIAL_ACPI=y, but CONFIG_SERIAL=m, the kernel (2.4.18-pre9) doesn't
link because early_serial_setup() is not found.

I think the correct fix is to not allow CONFIG_SERIAL_ACPI, unless
CONFIG_SERIAL=y.


Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

Dave Jones Feb. 8, 2002, 12:43 p.m. UTC | #1
On Fri, Feb 08, 2002 at 01:25:07PM +0100, Geert Uytterhoeven wrote:
 > 
 > If CONFIG_SERIAL_ACPI=y, but CONFIG_SERIAL=m, the kernel (2.4.18-pre9) doesn't
 > link because early_serial_setup() is not found.
 > 
 > I think the correct fix is to not allow CONFIG_SERIAL_ACPI, unless
 > CONFIG_SERIAL=y.

 Isn't CONFIG_SERIAL_ACPI an ia64 only option ?
Geert Uytterhoeven Feb. 8, 2002, 12:52 p.m. UTC | #2
On Fri, 8 Feb 2002, Dave Jones wrote:
> On Fri, Feb 08, 2002 at 01:25:07PM +0100, Geert Uytterhoeven wrote:
>  > If CONFIG_SERIAL_ACPI=y, but CONFIG_SERIAL=m, the kernel (2.4.18-pre9) doesn't
>  > link because early_serial_setup() is not found.
>  > 
>  > I think the correct fix is to not allow CONFIG_SERIAL_ACPI, unless
>  > CONFIG_SERIAL=y.
> 
>  Isn't CONFIG_SERIAL_ACPI an ia64 only option ?

It's not protected by a test for ia64, only by a test for CONFIG_ACPI, and its
Configure.help entry didn't tell me anything suspicious, so I enabled it for my
Vaio.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Pavel Machek Feb. 9, 2002, 8:13 p.m. UTC | #3
Hi!

>  > If CONFIG_SERIAL_ACPI=y, but CONFIG_SERIAL=m, the kernel (2.4.18-pre9) doesn't
>  > link because early_serial_setup() is not found.
>  > 
>  > I think the correct fix is to not allow CONFIG_SERIAL_ACPI, unless
>  > CONFIG_SERIAL=y.
> 
>  Isn't CONFIG_SERIAL_ACPI an ia64 only option ?

No, AFAIK.
									Pavel

Patch

--- linux-tux-2.4.18-pre9/drivers/char/Config.in.orig	Fri Feb  8 09:38:36 2002
+++ linux-tux-2.4.18-pre9/drivers/char/Config.in	Fri Feb  8 13:23:25 2002
@@ -15,9 +15,9 @@ 
       tristate '   Atomwide serial port support' CONFIG_ATOMWIDE_SERIAL
       tristate '   Dual serial port support' CONFIG_DUALSP_SERIAL
    fi
-fi
-if [ "$CONFIG_ACPI" = "y" ]; then
-   bool '  Support for serial ports defined by ACPI tables' CONFIG_SERIAL_ACPI
+   if [ "$CONFIG_ACPI" = "y" ]; then
+      bool '  Support for serial ports defined by ACPI tables' CONFIG_SERIAL_ACPI
+   fi
 fi
 dep_mbool 'Extended dumb serial driver options' CONFIG_SERIAL_EXTENDED $CONFIG_SERIAL
 if [ "$CONFIG_SERIAL_EXTENDED" = "y" ]; then