From: Alexey Dobriyan <adobriyan@gmail.com>
To: tytso@mit.edu, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, acab@digitalfuture.it, stable@kernel.org
Subject: [PATCH] random: fix 32MB+ reads from /dev/urandom
Date: Wed, 23 Jul 2014 20:14:21 +0300 [thread overview]
Message-ID: <20140723171421.GA2997@p183.telecom.by> (raw)
https://bugzilla.kernel.org/show_bug.cgi?id=80981
Steps to reproduce:
strace dd if=/dev/urandom of=/dev/null bs=64M count=1
Before, dd did 1 read() syscall and returned full length.
Now, dd stops at 32 MB.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
STABLE needs 79a8468747c5f95ed3d5ce8376a3e82e0c5857fc
and this patch.
drivers/char/random.c | 24 ++++++++++++++++++------
1 file changed, 18 insertions(+), 6 deletions(-)
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -1377,20 +1377,32 @@ random_read(struct file *file, char __user *buf, size_t nbytes, loff_t *ppos)
}
static ssize_t
-urandom_read(struct file *file, char __user *buf, size_t nbytes, loff_t *ppos)
+urandom_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
{
- int ret;
+ ssize_t ret;
if (unlikely(nonblocking_pool.initialized == 0))
printk_once(KERN_NOTICE "random: %s urandom read "
"with %d bits of entropy available\n",
current->comm, nonblocking_pool.entropy_total);
- nbytes = min_t(size_t, nbytes, INT_MAX >> (ENTROPY_SHIFT + 3));
- ret = extract_entropy_user(&nonblocking_pool, buf, nbytes);
+ ret = 0;
+ while (count > 0) {
+ size_t count1;
+ ssize_t ret1;
+
+ count1 = min_t(size_t, count, INT_MAX >> (ENTROPY_SHIFT + 3));
+ ret1 = extract_entropy_user(&nonblocking_pool, buf, count1);
+ if (ret1 < 0)
+ return ret1;
- trace_urandom_read(8 * nbytes, ENTROPY_BITS(&nonblocking_pool),
- ENTROPY_BITS(&input_pool));
+ trace_urandom_read(8 * count1, ENTROPY_BITS(&nonblocking_pool),
+ ENTROPY_BITS(&input_pool));
+
+ buf += ret1;
+ count -= ret1;
+ ret += ret1;
+ }
return ret;
}
next reply other threads:[~2014-07-23 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 17:14 Alexey Dobriyan [this message]
2014-07-23 20:26 ` [PATCH] random: fix 32MB+ reads from /dev/urandom Theodore Ts'o
2014-08-09 7:48 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723171421.GA2997@p183.telecom.by \
--to=adobriyan@gmail.com \
--cc=acab@digitalfuture.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).