linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: Manfred Spraul <manfred@colorfullife.com>, torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Re: 2.5: further llseek cleanup (3/3)
Date: 16 Feb 2002 18:00:28 -0500	[thread overview]
Message-ID: <1013900429.855.3.camel@phantasy> (raw)
In-Reply-To: <3C6EDDCA.DAB884BD@colorfullife.com>
In-Reply-To: <3C6EDDCA.DAB884BD@colorfullife.com>

On Sat, 2002-02-16 at 17:31, Manfred Spraul wrote:
> Hi Robert,
> 
> I think the pcilynx change is wrong:

Indeed.  Thank you, Manfred.

Linus, patch against 2.5.5-pre1 is attached.  Please, apply.

	Robert Love

diff -urN linux-2.5.5-pre1/drivers/ieee1394/pcilynx.c linux/drivers/ieee1394/pcilynx.c
--- linux-2.5.5-pre1/drivers/ieee1394/pcilynx.c	Wed Feb 13 18:18:46 2002
+++ linux/drivers/ieee1394/pcilynx.c	Sat Feb 16 17:58:47 2002
@@ -748,10 +748,11 @@
         }
 
         if (newoffs < 0 || newoffs > PCILYNX_MAX_MEMORY + 1) {
-                lock_kernel();
+                unlock_kernel();
                 return -EINVAL;
         }
 
+        unlock_kernel();
         file->f_pos = newoffs;
         return newoffs;
 }



  reply	other threads:[~2002-02-16 23:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-16 22:31 [PATCH] 2.5: further llseek cleanup (3/3) Manfred Spraul
2002-02-16 23:00 ` Robert Love [this message]
2002-02-16 23:20 ` [PATCH] " Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1013900429.855.3.camel@phantasy \
    --to=rml@tech9.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).