Fix more "if ((err = foo() < 0))" typos
diff mbox series

Message ID 20060109210916.GA28806@mipter.zuzino.mipt.ru
State New, archived
Headers show
Series
  • Fix more "if ((err = foo() < 0))" typos
Related show

Commit Message

Alexey Dobriyan Jan. 9, 2006, 9:09 p.m. UTC
Another reason to use:

	ret = foo();
	if (ret < 0)
		goto out;

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 Documentation/kprobes.txt           |    3 ++-
 arch/mips/kernel/vpe.c              |    3 ++-
 drivers/media/dvb/frontends/mt312.c |    3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

diff -uprN linux-vanilla/Documentation/kprobes.txt linux-1/Documentation/kprobes.txt
--- linux-vanilla/Documentation/kprobes.txt	2006-01-09 16:02:19.000000000 +0300
+++ linux-1/Documentation/kprobes.txt	2006-01-09 23:59:12.000000000 +0300
@@ -411,7 +411,8 @@  int init_module(void)
 		printk("Couldn't find %s to plant kprobe\n", "do_fork");
 		return -1;
 	}
-	if ((ret = register_kprobe(&kp) < 0)) {
+	ret = register_kprobe(&kp);
+	if (ret < 0) {
 		printk("register_kprobe failed, returned %d\n", ret);
 		return -1;
 	}
diff -uprN linux-vanilla/arch/mips/kernel/vpe.c linux-1/arch/mips/kernel/vpe.c
--- linux-vanilla/arch/mips/kernel/vpe.c	2006-01-09 16:02:20.000000000 +0300
+++ linux-1/arch/mips/kernel/vpe.c	2006-01-10 00:00:35.000000000 +0300
@@ -1171,7 +1171,8 @@  static int __init vpe_module_init(void)
 		return -ENODEV;
 	}
 
-	if ((major = register_chrdev(0, module_name, &vpe_fops) < 0)) {
+	major = register_chrdev(0, module_name, &vpe_fops);
+	if (major < 0) {
 		printk("VPE loader: unable to register character device\n");
 		return major;
 	}
diff -uprN linux-vanilla/drivers/media/dvb/frontends/mt312.c linux-1/drivers/media/dvb/frontends/mt312.c
--- linux-vanilla/drivers/media/dvb/frontends/mt312.c	2006-01-09 16:02:22.000000000 +0300
+++ linux-1/drivers/media/dvb/frontends/mt312.c	2006-01-09 23:59:46.000000000 +0300
@@ -501,7 +501,8 @@  static int mt312_set_frontend(struct dvb
 	case ID_VP310:
 	// For now we will do this only for the VP310.
 	// It should be better for the mt312 as well, but tunning will be slower. ACCJr 09/29/03
-		if ((ret = mt312_readreg(state, CONFIG, &config_val) < 0))
+		ret = mt312_readreg(state, CONFIG, &config_val);
+		if (ret < 0)
 			return ret;
 		if (p->u.qpsk.symbol_rate >= 30000000) //Note that 30MS/s should use 90MHz
 		{