[-mm] mm/rmap.c: don't forget to include module.h
diff mbox series

Message ID 20060111165758.GH8686@mipter.zuzino.mipt.ru
State New, archived
Headers show
Series
  • [-mm] mm/rmap.c: don't forget to include module.h
Related show

Commit Message

Alexey Dobriyan Jan. 11, 2006, 4:57 p.m. UTC
CC      mm/rmap.o
mm/rmap.c:235: warning: type defaults to `int' in declaration of `EXPORT_SYMBOL'
mm/rmap.c:235: warning: parameter names (without types) in function declaration
mm/rmap.c:235: warning: data definition has no type or storage class

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 mm/rmap.c |    3 +++
 1 file changed, 3 insertions(+)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

Adrian Bunk Jan. 11, 2006, 9:42 p.m. UTC | #1
On Wed, Jan 11, 2006 at 07:57:58PM +0300, Alexey Dobriyan wrote:
>   CC      mm/rmap.o
> mm/rmap.c:235: warning: type defaults to `int' in declaration of `EXPORT_SYMBOL'
> mm/rmap.c:235: warning: parameter names (without types) in function declaration
> mm/rmap.c:235: warning: data definition has no type or storage class
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  mm/rmap.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- linux-2.6.15-mm3/mm/rmap.c	2006-01-11 19:42:39.000000000 +0300
> +++ linux-2.6.15-mm3-rmap/mm/rmap.c	2006-01-11 19:48:12.000000000 +0300
> @@ -52,6 +52,9 @@
>  #include <linux/init.h>
>  #include <linux/rmap.h>
>  #include <linux/rcupdate.h>
> +#ifdef CONFIG_MIGRATION
> +#include <linux/module.h>
> +#endif
>...

There's no need for an #ifdef.

cu
Adrian
Christoph Lameter Jan. 11, 2006, 9:50 p.m. UTC | #2
On Wed, 11 Jan 2006, Adrian Bunk wrote:

> There's no need for an #ifdef.

Correct. Just put the #include back.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

--- linux-2.6.15-mm3/mm/rmap.c	2006-01-11 19:42:39.000000000 +0300
+++ linux-2.6.15-mm3-rmap/mm/rmap.c	2006-01-11 19:48:12.000000000 +0300
@@ -52,6 +52,9 @@ 
 #include <linux/init.h>
 #include <linux/rmap.h>
 #include <linux/rcupdate.h>
+#ifdef CONFIG_MIGRATION
+#include <linux/module.h>
+#endif
 
 #include <asm/tlbflush.h>