small etherdevice.h fix
diff mbox series

Message ID Pine.LNX.4.62.0602032105180.31368@artax.karlin.mff.cuni.cz
State New, archived
Headers show
Series
  • small etherdevice.h fix
Related show

Commit Message

Mikulas Patocka Feb. 3, 2006, 8:08 p.m. UTC
Hi

This fixes a small bug in is_valid_ether_addr --- for address in the form 
FF:xx:xx:xx:xx:xx it returns true. The comment is about FF:FF:FF:FF:FF:FF 
is not true, is_multicast_ether_addr doesn't accept FF:FF:FF:FF:FF:FF as 
multicast (as you can see few lines above).

Mikulas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

Stephen Hemminger Feb. 3, 2006, 9:22 p.m. UTC | #1
On Fri, 3 Feb 2006 21:08:23 +0100 (CET)
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> wrote:

> Hi
> 
> This fixes a small bug in is_valid_ether_addr --- for address in the form 
> FF:xx:xx:xx:xx:xx it returns true. The comment is about FF:FF:FF:FF:FF:FF 
> is not true, is_multicast_ether_addr doesn't accept FF:FF:FF:FF:FF:FF as 
> multicast (as you can see few lines above).
> 
> Mikulas
> 
> --- include/linux/etherdevice.h_	2006-02-03 21:05:23.000000000 +0100
> +++ include/linux/etherdevice.h	2006-02-03 21:05:59.000000000 +0100
> @@ -91,9 +91,7 @@
>    */
>   static inline int is_valid_ether_addr(const u8 *addr)
>   {
> -	/* FF:FF:FF:FF:FF:FF is a multicast address so we don't need to
> -	 * explicitly check for it here. */
> -	return !is_multicast_ether_addr(addr) && !is_zero_ether_addr(addr);
> +	return !(addr[0] & 1) && !is_zero_ether_addr(addr);
>   }
> 
>   /**

It has already been fixed in 2.6.16 is_multicast_addr is now:

static inline int is_multicast_ether_addr(const u8 *addr)
{
	return (0x01 & addr[0]);
}

Patch
diff mbox series

--- include/linux/etherdevice.h_	2006-02-03 21:05:23.000000000 +0100
+++ include/linux/etherdevice.h	2006-02-03 21:05:59.000000000 +0100
@@ -91,9 +91,7 @@ 
   */
  static inline int is_valid_ether_addr(const u8 *addr)
  {
-	/* FF:FF:FF:FF:FF:FF is a multicast address so we don't need to
-	 * explicitly check for it here. */
-	return !is_multicast_ether_addr(addr) && !is_zero_ether_addr(addr);
+	return !(addr[0] & 1) && !is_zero_ether_addr(addr);
  }

  /**