From: Daniel Yeisley <dan.yeisley@unisys.com>
To: linux-kernel@vger.kernel.org
Cc: torvalds@osdl.org, ak@suse.de, shai@scalex86.org,
kiran@scalex86.org, alokk@calsoftinc.com
Subject: [PATCH] x86_64 Early initialization of cpu_to_node
Date: Tue, 14 Feb 2006 13:08:08 -0500 [thread overview]
Message-ID: <1139940489.2776.24.camel@localhost.localdomain> (raw)
The early initialization of cpu_to_node code as it is now only updates
the cpu_to_node array, and does not update cpu_pda()->nodemember. This
will cause numa_node_id() to return 0 on systems where CPU 0 is not on
Node 0. This leads to a kernel panic in slab.c.
I've tested the patch below on a 16 processor x86_64 ES7000-600 server,
and no longer see the panic I saw with the original 2.6.16-rc3.
Signed-off-by: Dan Yeisley <dan.yeisley@unisys.com>
---
diff -Naur -p linux-2.6.16-rc3/arch/x86_64/mm/numa.c linux-2.6.16-rc3-a/arch/x86_64/mm/numa.c
--- linux-2.6.16-rc3/arch/x86_64/mm/numa.c 2006-02-12 19:27:25.000000000 -0500
+++ linux-2.6.16-rc3-a/arch/x86_64/mm/numa.c 2006-02-14 08:36:10.000000000 -0500
@@ -351,7 +351,7 @@ void __init init_cpu_to_node(void)
continue;
if (apicid_to_node[apicid] == NUMA_NO_NODE)
continue;
- cpu_to_node[i] = apicid_to_node[apicid];
+ numa_set_node(i,apicid_to_node[apicid]);
}
}
reply other threads:[~2006-02-14 18:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139940489.2776.24.camel@localhost.localdomain \
--to=dan.yeisley@unisys.com \
--cc=ak@suse.de \
--cc=alokk@calsoftinc.com \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shai@scalex86.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).