From: Stephen Rothwell <sfr@canb.auug.org.au>
To: marcelo.tosatti@cyclades.com
Cc: paulus@samba.org, ppc64-dev <linuxppc64-dev@ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] Signal hadnling fix for 2.4
Date: Mon, 27 Feb 2006 16:03:37 +1100 [thread overview]
Message-ID: <20060227160337.65610906.sfr@canb.auug.org.au> (raw)
Hi Marcelo,
While investigating a bug report about a 64bit application that crashed in
malloc, Paul Mackerras noticed that sys_rt_sigreturn's return value was
"int". It needs to be "long" or else the return value of a syscall that
is interrupted by a signal will be truncated to 32 bits and then sign
extended. This causes .e.g mmap's return value to be corrupted if it is
returning an address above 2^31 (which is what caused a SEGV in malloc).
This problem obviously only affects 64 bit processes.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
Please apply for 2.4.33, this patch is against 2.4.33-pre2.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
diff -ruN linux/arch/ppc64/kernel/signal.c linux-sfr/arch/ppc64/kernel/signal.c
--- linux/arch/ppc64/kernel/signal.c 2006-02-24 17:37:08.000000000 +1100
+++ linux-sfr/arch/ppc64/kernel/signal.c 2006-02-27 11:05:07.000000000 +1100
@@ -332,7 +332,7 @@
}
-asmlinkage int
+asmlinkage long
sys_rt_sigreturn(unsigned long r3, unsigned long r4, unsigned long r5,
unsigned long r6, unsigned long r7, unsigned long r8,
struct pt_regs *regs)
next reply other threads:[~2006-02-27 5:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-27 5:03 Stephen Rothwell [this message]
2006-02-28 4:01 ` [PATCH] Signal hadnling fix for 2.4 Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060227160337.65610906.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).