From: Rusty Russell <rusty@rustcorp.com.au>
To: viro@math.psu.edu
Cc: linux-kernel@vger.kernel.org
Subject: (FORWARD) René Scharfe: [PATCH] MSDOS filesystem option mistreatment
Date: Wed, 13 Mar 2002 15:31:14 +1100 [thread overview]
Message-ID: <E16l0Py-0005nk-00@wagner.rustcorp.com.au> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3212 bytes --]
This seems correct. Al?
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
------- Forwarded Message
Date: Tue, 12 Mar 2002 23:07:58 +0100
From: René Scharfe <l.s.r@web.de>
To: trivial@rustcorp.com.au
Subject: [PATCH] MSDOS filesystem option mistreatment
Message-Id: <20020312230758.243bb4cf.l.s.r@web.de>
Hello,
this fixes a longstanding buglet in kernels 2.4 and 2.5, where
the MSDOS filesystem would ignore its 'check' mount option.
René
diff -ur linux-2.5.6/fs/msdos/namei.c linux-2.5.6-fat/fs/msdos/namei.c
--- linux-2.5.6/fs/msdos/namei.c Wed Feb 20 19:49:06 2002
+++ linux-2.5.6-fat/fs/msdos/namei.c Tue Mar 12 22:50:58 2002
@@ -42,9 +42,10 @@
/***** Formats an MS-DOS file name. Rejects invalid names. */
static int msdos_format_name(const char *name,int len,
char *res,struct fat_mount_options *opts)
- /* conv is relaxed/normal/strict, name is proposed name,
- * len is the length of the proposed name, res is the result name,
- * dotsOK is if hidden files get dots.
+ /* name is the proposed name, len is its length, res is
+ * the resulting name, opts->name_check is either (r)elaxed,
+ * (n)ormal or (s)trict, opts->dotsOK allows dots at the
+ * beginning of name (for hidden files)
*/
{
char *walk;
@@ -66,11 +67,11 @@
for (walk = res; len && walk-res < 8; walk++) {
c = *name++;
len--;
- if (opts->conversion != 'r' && strchr(bad_chars,c))
+ if (opts->name_check != 'r' && strchr(bad_chars,c))
return -EINVAL;
- if (opts->conversion == 's' && strchr(bad_if_strict(opts),c))
+ if (opts->name_check == 's' && strchr(bad_if_strict(opts),c))
return -EINVAL;
- if (c >= 'A' && c <= 'Z' && opts->conversion == 's')
+ if (c >= 'A' && c <= 'Z' && opts->name_check == 's')
return -EINVAL;
if (c < ' ' || c == ':' || c == '\\') return -EINVAL;
/* 0xE5 is legal as a first character, but we must substitute 0x05 */
@@ -83,7 +84,7 @@
*walk = (!opts->nocase && c >= 'a' && c <= 'z') ? c-32 : c;
}
if (space) return -EINVAL;
- if (opts->conversion == 's' && len && c != '.') {
+ if (opts->name_check == 's' && len && c != '.') {
c = *name++;
len--;
if (c != '.') return -EINVAL;
@@ -94,25 +95,25 @@
while (len > 0 && walk-res < MSDOS_NAME) {
c = *name++;
len--;
- if (opts->conversion != 'r' && strchr(bad_chars,c))
+ if (opts->name_check != 'r' && strchr(bad_chars,c))
return -EINVAL;
- if (opts->conversion == 's' &&
+ if (opts->name_check == 's' &&
strchr(bad_if_strict(opts),c))
return -EINVAL;
if (c < ' ' || c == ':' || c == '\\')
return -EINVAL;
if (c == '.') {
- if (opts->conversion == 's')
+ if (opts->name_check == 's')
return -EINVAL;
break;
}
- if (c >= 'A' && c <= 'Z' && opts->conversion == 's')
+ if (c >= 'A' && c <= 'Z' && opts->name_check == 's')
return -EINVAL;
space = c == ' ';
*walk++ = (!opts->nocase && c >= 'a' && c <= 'z') ? c-32 : c;
}
if (space) return -EINVAL;
- if (opts->conversion == 's' && len) return -EINVAL;
+ if (opts->name_check == 's' && len) return -EINVAL;
}
while (walk-res < MSDOS_NAME) *walk++ = ' ';
if (!opts->atari)
------- End of Forwarded Message
next reply other threads:[~2002-03-13 4:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-13 4:31 Rusty Russell [this message]
2002-03-13 4:35 ` (FORWARD) RenИ Scharfe: [PATCH] MSDOS filesystem option mistreatment Alexander Viro
2002-03-13 5:01 ` (FORWARD) =?unknown-8bit?Q?Ren=E9_Scharfe=3A?= [PATCH] MS DOS " Andreas Dilger
2002-03-13 14:36 ` (FORWARD) René Scharfe: " OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E16l0Py-0005nk-00@wagner.rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).