From: Dave Hansen <haveblue@us.ibm.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, ak@suse.de, gregkh@suse.de,
Dave Hansen <haveblue@us.ibm.com>
Subject: [PATCH] kill implicit check_acpi_pci() warning
Date: Thu, 16 Mar 2006 16:28:35 -0800 [thread overview]
Message-ID: <20060317002835.FDAEA381@localhost.localdomain> (raw)
I've been seeing these in recent -mms:
arch/i386/kernel/setup.c: In function `setup_arch':
arch/i386/kernel/setup.c:1523: warning: implicit declaration of function `check_acpi_pci'
The issue is that the stub check_acpi_pci() is inside an
#ifdef ACPI in the header, while the actual use inside the
.c file is not. I've elected to take both the extern and
the stub in the header, and take them out of the ACPI #ifdef.
The comment next to the call says the following:
check_acpi_pci(); /* Checks more than just ACPI actually */
Seems weird to have "_acpi_" in it then, but what do I know?
BTW, I'm running a config with ACPI=n and X86_IO_APIC=y.
---
work-dave/include/asm-i386/acpi.h | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff -puN arch/i386/kernel/setup.c~kill-implicit-check_acpi_pci-warning arch/i386/kernel/setup.c
diff -puN include/asm-i386/acpi.h~kill-implicit-check_acpi_pci-warning include/asm-i386/acpi.h
--- work/include/asm-i386/acpi.h~kill-implicit-check_acpi_pci-warning 2006-03-16 16:25:59.000000000 -0800
+++ work-dave/include/asm-i386/acpi.h 2006-03-16 16:25:59.000000000 -0800
@@ -128,8 +128,6 @@ extern int acpi_gsi_to_irq(u32 gsi, unsi
extern int skip_ioapic_setup;
extern int acpi_skip_timer_override;
-extern void check_acpi_pci(void);
-
static inline void disable_ioapic_setup(void)
{
skip_ioapic_setup = 1;
@@ -142,7 +140,6 @@ static inline int ioapic_setup_disabled(
#else
static inline void disable_ioapic_setup(void) { }
-static inline void check_acpi_pci(void) { }
#endif
@@ -163,6 +160,11 @@ static inline void acpi_disable_pci(void
#endif /* !CONFIG_ACPI */
+#ifdef CONFIG_X86_IO_APIC
+extern void check_acpi_pci(void);
+#else
+static inline void check_acpi_pci(void) { }
+#endif
#ifdef CONFIG_ACPI_SLEEP
_
reply other threads:[~2006-03-17 0:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060317002835.FDAEA381@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).