From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: matt.fleming@intel.com, ard.biesheuvel@linaro.org
Cc: leif.lindholm@linaro.org, linux-kernel@vger.kernel.org,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Subject: [Patch 2/3] firmware: dmi_scan: fix dmi_len type
Date: Wed, 11 Feb 2015 11:46:31 +0200 [thread overview]
Message-ID: <1423647992-3787-3-git-send-email-ivan.khoronzhuk@linaro.org> (raw)
In-Reply-To: <1423647992-3787-1-git-send-email-ivan.khoronzhuk@linaro.org>
According to SMBIOSv3 specification the length of DMI table can be
up to 32bits wide. So use appropriate type to avoid overflow.
It's obvious that dmi_num theoretically can be more than u16 also,
so it's can be changed to u32 or at least it's better to use int
instead of u16, but on that moment I cannot imagine dmi structure
count more than 65535 and it can require changing type of vars that
work with it. So I didn't correct it.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
drivers/firmware/dmi_scan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index fb16203..952e95c 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -18,7 +18,7 @@
static const char dmi_empty_string[] = " ";
static u16 __initdata dmi_ver;
-static u16 dmi_len;
+static u32 dmi_len;
static u16 dmi_num;
/*
* Catch too early calls to dmi_check_system():
--
1.9.1
next prev parent reply other threads:[~2015-02-11 9:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 9:46 [Patch 0/3] firmware: dmi_scan: add some SMBIOSv3 corrections Ivan Khoronzhuk
2015-02-11 9:46 ` [Patch 1/3] firmware: dmi_scan: use direct access to static vars Ivan Khoronzhuk
2015-02-11 9:46 ` Ivan Khoronzhuk [this message]
2015-02-11 9:53 ` [Patch 2/3] firmware: dmi_scan: fix dmi_len type Ard Biesheuvel
2015-02-11 10:10 ` Ivan Khoronzhuk
2015-02-11 10:12 ` Ard Biesheuvel
2015-02-13 16:12 ` Matt Fleming
2015-02-15 7:11 ` Ivan Khoronzhuk
2015-02-11 9:46 ` [Patch 3/3] firmware: dmi_scan: use full dmi version for SMBIOS3 Ivan Khoronzhuk
2015-02-11 9:55 ` Ard Biesheuvel
2015-02-11 10:08 ` Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423647992-3787-3-git-send-email-ivan.khoronzhuk@linaro.org \
--to=ivan.khoronzhuk@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).