From: Patrick McHardy <kaber@trash.net>
To: Alexey Kuznetsov <kuznet2@ms2.inr.ac.ru>
Cc: linux-kernel@vger.kernel.org
Subject: bug in sch_generic.c:pfifo_fast_enqueue
Date: Mon, 1 Apr 2002 21:43:03 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.44.0204012131330.13230-200000@el-zoido.localnet> (raw)
[-- Attachment #1: Type: TEXT/PLAIN, Size: 220 bytes --]
Hi Alexey.
I found a small bug in pfifo_fast_enqueue, instead of
if (list->qlen <= skb->dev->tx_queue_len)
it should be
if (list->qlen <= qdisc->dev->tx_queue_len)
i guess. the attached patch fixes it.
Bye,
Patrick
[-- Attachment #2: Type: TEXT/PLAIN, Size: 533 bytes --]
diff -urN linux-2.4.18-clean/net/sched/sch_generic.c linux-2.4.18-sched_fixed/net/sched/sch_generic.c
--- linux-2.4.18-clean/net/sched/sch_generic.c Fri Aug 18 19:26:25 2000
+++ linux-2.4.18-sched_fixed/net/sched/sch_generic.c Sat Mar 30 11:45:56 2002
@@ -280,7 +280,7 @@
list = ((struct sk_buff_head*)qdisc->data) +
prio2band[skb->priority&TC_PRIO_MAX];
- if (list->qlen <= skb->dev->tx_queue_len) {
+ if (list->qlen <= qdisc->dev->tx_queue_len) {
__skb_queue_tail(list, skb);
qdisc->q.qlen++;
return 0;
next reply other threads:[~2002-04-01 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-01 19:43 Patrick McHardy [this message]
2002-04-11 4:41 ` bug in sch_generic.c:pfifo_fast_enqueue David S. Miller
2002-04-11 13:56 ` Patrick McHardy
2002-04-24 17:51 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0204012131330.13230-200000@el-zoido.localnet \
--to=kaber@trash.net \
--cc=kuznet2@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).