linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dominik Brodowski <devel@brodo.de>
To: "Luis Falcon" <lfalcon@thymbra.com>, devel@brodo.de
Cc: <linux-kernel@vger.kernel.org>
Subject: [patch] Re: IRQ routing conflicts / Assigning IRQ 0 to ethernet
Date: Wed, 3 Apr 2002 00:07:53 +0200	[thread overview]
Message-ID: <02040300075302.00816@sonnenschein> (raw)
In-Reply-To: <32954.200.45.226.162.1017776187.squirrel@thymbra.com> <19566.1017784479@www7.gmx.net>

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

Luis:

This patch should resolve the remaining issues. Patch is against 
acpi-20020329 + 2.5.7/2.4.18. Please test + tell me if it works.

Dominik

--- linux/arch/i386/kernel/pci-irq.c.original	Tue Apr  2 13:35:24 2002
+++ linux/arch/i386/kernel/pci-irq.c	Tue Apr  2 13:47:23 2002
@@ -576,10 +576,8 @@
 	struct pci_dev *dev2;
 	char *msg = NULL;
 
-	if (!pirq_table)
-		return 0;
 
-	/* Find IRQ routing entry */
+	/* Find IRQ pin */
 	pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
 	if (!pin) {
 		DBG(" -> no interrupt pin\n");
@@ -588,10 +586,17 @@
 	pin = pin - 1;
 
 #ifdef CONFIG_ACPI_PCI
+	/* Use ACPI to lookup IRQ */
+
 	if (pci_use_acpi_routing)
 		return acpi_lookup_irq(dev, pin, assign);
 #endif
 	
+	/* Find IRQ routing entry */
+
+	if (!pirq_table)
+		return 0;
+
 	DBG("IRQ for %s:%d", dev->slot_name, pin);
 	info = pirq_get_info(dev);
 	if (!info) {


On Tuesday,  2. April 2002 23:54, Luis Falcon wrote:
> Bryan,
>
> Thanks a lot for your response.
> In fact the IRQ routing conflict has been solved !
>
> What is still pending is the assignment of a valid IRQ to the Ethernet card
> ( device 00:05.0 ) and Sound Card ( 00:07.5 ). So, at this point, the
> ethernet card doesn't work.
>  does not work.
>
> Here's the latest dmesg.
>
> Regards,
> Luis

[-- Attachment #2: pci-irq1.1.acpi.diff --]
[-- Type: text/x-c, Size: 726 bytes --]

--- linux/arch/i386/kernel/pci-irq.c.original	Tue Apr  2 13:35:24 2002
+++ linux/arch/i386/kernel/pci-irq.c	Tue Apr  2 13:47:23 2002
@@ -576,10 +576,8 @@
 	struct pci_dev *dev2;
 	char *msg = NULL;
 
-	if (!pirq_table)
-		return 0;
 
-	/* Find IRQ routing entry */
+	/* Find IRQ pin */
 	pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
 	if (!pin) {
 		DBG(" -> no interrupt pin\n");
@@ -588,10 +586,17 @@
 	pin = pin - 1;
 
 #ifdef CONFIG_ACPI_PCI
+	/* Use ACPI to lookup IRQ */
+
 	if (pci_use_acpi_routing)
 		return acpi_lookup_irq(dev, pin, assign);
 #endif
 	
+	/* Find IRQ routing entry */
+
+	if (!pirq_table)
+		return 0;
+
 	DBG("IRQ for %s:%d", dev->slot_name, pin);
 	info = pirq_get_info(dev);
 	if (!info) {

  parent reply	other threads:[~2002-04-02 22:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-02 19:36 IRQ routing conflicts / Assigning IRQ 0 to ethernet Luis Falcon
     [not found] ` <19566.1017784479@www7.gmx.net>
2002-04-02 22:07   ` Dominik Brodowski [this message]
2002-04-03 20:24     ` [patch] " Luis Falcon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02040300075302.00816@sonnenschein \
    --to=devel@brodo.de \
    --cc=lfalcon@thymbra.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).