From: Lukasz Trabinski <lukasz@lt.wsisiz.edu.pl>
To: <linux-kernel@vger.kernel.org>
Cc: <alan@lxorguk.ukuu.org.uk>, <tytso@valinux.com>
Subject: [patch] 2.2.18 PCI_DEVICE_ID_OXSEMI_16PCI954
Date: Fri, 15 Dec 2000 21:57:42 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.30.0012152140350.3740-100000@lt.wsisiz.edu.pl> (raw)
Hello
I'm tring to use serial driver 5.05 with kernel in version
2.2.18. There is a little problem with vendor definition in kernel source.
In serial dirver from Theodore Ts'o we have:
{ PCI_VENDOR_ID_SPECIALIX, PCI_DEVICE_ID_OXSEMI_16PCI954,
PCI_VENDOR_ID_SPECIALIX,
PCI_SUBDEVICE_ID_SPECIALIX_SPEED4,
SPCI_FL_BASE0 , 4, 921600 },
{ PCI_VENDOR_ID_OXSEMI, PCI_DEVICE_ID_OXSEMI_16PCI954,
PCI_ANY_ID, PCI_ANY_ID,
SPCI_FL_BASE0 , 4, 115200 },
In kernel 2.4.0-test11 we have:
[lukasz@lt linux]$ grep PCI_DEVICE_ID_OXSEMI_16PCI954 * -r
drivers/char/serial.c: { PCI_VENDOR_ID_SPECIALIX,
PCI_DEVICE_ID_OXSEMI_16PCI954,
drivers/char/serial.c: { PCI_VENDOR_ID_OXSEMI,
PCI_DEVICE_ID_OXSEMI_16PCI954,
include/linux/pci_ids.h:#define PCI_DEVICE_ID_OXSEMI_16PCI954 0x9501
(IMHO that is correct), but in kernel 2.2.18 we have:
(include/kernel/pci.h)
#define PCI_DEVICE_ID_OXSEMI_16PCI954PP 0x9513
^^
Please correct, if I'm wrong, but IMHO it shuld be:
(include/kernel/pci.h)
#define PCI_DEVICE_ID_OXSEMI_16PCI954 0x9513
There is a simple patch to fix that:
diff -r -u linux.org/include/linux/pci.h linux/include/linux/pci.h
--- linux.org/include/linux/pci.h Mon Dec 11 01:49:44 2000
+++ linux/include/linux/pci.h Fri Dec 15 21:38:14 2000
@@ -1097,7 +1097,7 @@
#define PCI_VENDOR_ID_OXSEMI 0x1415
#define PCI_DEVICE_ID_OXSEMI_12PCI840 0x8403
-#define PCI_DEVICE_ID_OXSEMI_16PCI954PP 0x9513
+#define PCI_DEVICE_ID_OXSEMI_16PCI954 0x9513
#define PCI_VENDOR_ID_AFAVLAB 0x14db
#define PCI_DEVICE_ID_AFAVLAB_TK9902 0x2120
--
*[ Łukasz Trąbiński ]*
SysAdmin @wsisiz.edu.pl
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2000-12-15 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-15 20:57 Lukasz Trabinski [this message]
2000-12-15 23:04 ` [patch] 2.2.18 PCI_DEVICE_ID_OXSEMI_16PCI954 Bruce Korb
2000-12-16 23:21 ` Tim Waugh
2000-12-17 0:51 ` Lukasz Trabinski
2000-12-17 10:18 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.30.0012152140350.3740-100000@lt.wsisiz.edu.pl \
--to=lukasz@lt.wsisiz.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@valinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).