From: Stelian Pop <stelian.pop@fr.alcove.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: rml@tech9.net
Subject: [PATCH 2.5.8-pre1] ppp_deflate.c fix...
Date: Thu, 4 Apr 2002 16:10:25 +0200 [thread overview]
Message-ID: <20020404141025.GI9820@come.alcove-fr> (raw)
When compiling 2.5.8-pre1 without CONFIG_PREEMPT, and ppp all in modules,
I have unresolved symbols in ppp_deflate.o (local_bh_enable and
local_bh_disable). If CONFIG_PREEMPT is on, no problems.
The attached patch fixes it by adding some header files to ppp_deflate.c which
somehow makes it properly compile.
But after a second look, I must say I don't really understand how this is
supposed to work, for example:
include/linux/spinlock.h
* defines spin_lock_bh dependent on local_bh_disable
* defines preempt_disable
include/asm-i386/softirq.h
* defines local_bh_disable dependent on ... preempt_disable
Do we have here a circular dependency problem or ?
Stelian.
===== drivers/net/ppp_deflate.c 1.6 vs edited =====
--- 1.6/drivers/net/ppp_deflate.c Mon Mar 4 14:20:25 2002
+++ edited/drivers/net/ppp_deflate.c Thu Apr 4 14:31:05 2002
@@ -36,11 +36,13 @@
#include <linux/vmalloc.h>
#include <linux/init.h>
#include <linux/smp_lock.h>
+#include <linux/spinlock.h>
#include <linux/ppp_defs.h>
#include <linux/ppp-comp.h>
#include <linux/zlib.h>
+#include <linux/interrupt.h>
static spinlock_t comp_free_list_lock = SPIN_LOCK_UNLOCKED;
static LIST_HEAD(comp_free_list);
--
Stelian Pop <stelian.pop@fr.alcove.com>
Alcove - http://www.alcove.com
reply other threads:[~2002-04-04 14:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020404141025.GI9820@come.alcove-fr \
--to=stelian.pop@fr.alcove.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).