From: Daiki Matsuda <dyky@df-usa.com>
To: linux-kernel@vger.kernel.org
Subject: 2.4.0-test13-pre2 has problems
Date: Sat, 16 Dec 2000 10:22:36 -0800 [thread overview]
Message-ID: <20001216102236W.dyky@df-usa.com> (raw)
[-- Attachment #1: Type: Text/Plain, Size: 523 bytes --]
Hi, all.
I'm trying kernel 2.4.0-test13-pre2. But it has a problem in
CONFIG_ATM.
In net/Config.in, we seletct CONFIG_ATM by bool, CONFIG_ATM_LANE
and CONFIG_ATM_MPOA by tristate. But net/atm/common.c calls two
function i.e. atm_lane_init and atm_mpoa_init, there also in
net/atm/{lane_mpoa_init.c,mpoa_caches.c}. When CONFIG_ATM_LANE or
CONFIG_ATM_MPOA is defined as module, the two functions are
unreferenced. So, I will put a simple patch. But I feel its patch
redundancy against two *.c files.
Regards
Daiki Matsuda
[-- Attachment #2: net.atm.commn.c.patch --]
[-- Type: Text/Plain, Size: 1166 bytes --]
--- linux/net/atm/common.c.old Fri Dec 15 23:48:51 2000
+++ linux/net/atm/common.c Sat Dec 16 00:07:29 2000
@@ -607,8 +607,10 @@
#if defined(CONFIG_ATM_LANE) || defined(CONFIG_ATM_LANE_MODULE)
case ATMLEC_CTRL:
if (!capable(CAP_NET_ADMIN)) return -EPERM;
+#ifndef CONFIG_ATM_LANE_MODULE
if (atm_lane_ops.lecd_attach == NULL)
atm_lane_init();
+#endif
if (atm_lane_ops.lecd_attach == NULL) /* try again */
return -ENOSYS;
error = atm_lane_ops.lecd_attach(vcc, (int)arg);
@@ -624,8 +626,10 @@
#if defined(CONFIG_ATM_MPOA) || defined(CONFIG_ATM_MPOA_MODULE)
case ATMMPC_CTRL:
if (!capable(CAP_NET_ADMIN)) return -EPERM;
+#ifndef CONFIG_ATM_MPOA_MODULE
if (atm_mpoa_ops.mpoad_attach == NULL)
atm_mpoa_init();
+#endif
if (atm_mpoa_ops.mpoad_attach == NULL) /* try again */
return -ENOSYS;
error = atm_mpoa_ops.mpoad_attach(vcc, (int)arg);
reply other threads:[~2000-12-16 18:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001216102236W.dyky@df-usa.com \
--to=dyky@df-usa.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).