nios2: Export get_cycles
diff mbox series

Message ID 20150609044646.GA6892@gondor.apana.org.au
State New, archived
Headers show
Series
  • nios2: Export get_cycles
Related show

Commit Message

Herbert Xu June 9, 2015, 4:46 a.m. UTC
On Mon, Jun 08, 2015 at 09:31:54PM -0700, Guenter Roeck wrote:
> 
> nios2 still fails to build with
> 
> ERROR: "get_cycles" [crypto/jitterentropy.ko] undefined!

It's the only arch that doesn't inline get_cycles and doesn't
export it.

---8<---
nios2 is the only architecture that does not inline get_cycles
and does not export it.  This breaks crypto as it uses get_cycles
in a number of modules.

Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Comments

Stephen Rothwell June 9, 2015, 5:19 a.m. UTC | #1
Hi Herbert,

On Tue, 9 Jun 2015 12:46:46 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Mon, Jun 08, 2015 at 09:31:54PM -0700, Guenter Roeck wrote:
> > 
> > nios2 still fails to build with
> > 
> > ERROR: "get_cycles" [crypto/jitterentropy.ko] undefined!
> 
> It's the only arch that doesn't inline get_cycles and doesn't
> export it.
> 
> ---8<---
> nios2 is the only architecture that does not inline get_cycles
> and does not export it.  This breaks crypto as it uses get_cycles
> in a number of modules.
> 
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Also added into linux-next today.

I am assuming that they will turn up in the crypto tree soon(ish).
Herbert Xu June 9, 2015, 5:50 a.m. UTC | #2
On Tue, Jun 09, 2015 at 03:19:32PM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> On Tue, 9 Jun 2015 12:46:46 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> > On Mon, Jun 08, 2015 at 09:31:54PM -0700, Guenter Roeck wrote:
> > > 
> > > nios2 still fails to build with
> > > 
> > > ERROR: "get_cycles" [crypto/jitterentropy.ko] undefined!
> > 
> > It's the only arch that doesn't inline get_cycles and doesn't
> > export it.
> > 
> > ---8<---
> > nios2 is the only architecture that does not inline get_cycles
> > and does not export it.  This breaks crypto as it uses get_cycles
> > in a number of modules.
> > 
> > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> Also added into linux-next today.
> 
> I am assuming that they will turn up in the crypto tree soon(ish).

Yes I'll be adding them to cryptodev.

Thanks,

Patch
diff mbox series

diff --git a/arch/nios2/kernel/time.c b/arch/nios2/kernel/time.c
index 7f45474..be186a7 100644
--- a/arch/nios2/kernel/time.c
+++ b/arch/nios2/kernel/time.c
@@ -8,6 +8,7 @@ 
  * for more details.
  */
 
+#include <linux/export.h>
 #include <linux/interrupt.h>
 #include <linux/clockchips.h>
 #include <linux/clocksource.h>
@@ -106,6 +107,7 @@  cycles_t get_cycles(void)
 {
 	return nios2_timer_read(&nios2_cs.cs);
 }
+EXPORT_SYMBOL(get_cycles);
 
 static void nios2_timer_start(struct nios2_timer *timer)
 {