From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org
Cc: David Brownell <david-b@pacbell.net>,
David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 04/10] SPI: spi bounce buffer has a minimum length
Date: Tue, 16 May 2006 14:38:32 -0700 [thread overview]
Message-ID: <1147815518897-git-send-email-greg@kroah.com> (raw)
In-Reply-To: <11478155181381-git-send-email-greg@kroah.com>
From: David Brownell <david-b@pacbell.net>
Make sure that spi_write_then_read() can always handle at least 32 bytes
of transfer (total, both directions), minimizing one portability issue.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/spi/spi.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
a9948b6194b46e489aa3b4d111d6dfd786c39c4b
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 94f5e8e..1168ef0 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -522,7 +522,8 @@ int spi_sync(struct spi_device *spi, str
}
EXPORT_SYMBOL_GPL(spi_sync);
-#define SPI_BUFSIZ (SMP_CACHE_BYTES)
+/* portable code must never pass more than 32 bytes */
+#define SPI_BUFSIZ max(32,SMP_CACHE_BYTES)
static u8 *buf;
--
1.3.2
next prev parent reply other threads:[~2006-05-16 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 21:37 [GIT PATCH] SPI patches for 2.6.17-rc4 Greg KH
2006-05-16 21:38 ` [PATCH 01/10] SPI: per-transfer overrides for wordsize and clocking Greg KH
2006-05-16 21:38 ` [PATCH 02/10] SPI: add PXA2xx SSP SPI Driver Greg KH
2006-05-16 21:38 ` [PATCH 03/10] SPI: spi whitespace fixes Greg KH
2006-05-16 21:38 ` Greg KH [this message]
2006-05-16 21:38 ` [PATCH 05/10] SPI: Add David as the SPI subsystem maintainer Greg KH
2006-05-16 21:38 ` [PATCH 06/10] SPI: Renamed bitbang_transfer_setup to spi_bitbang_setup_transfer and export it Greg KH
2006-05-16 21:38 ` [PATCH 07/10] SPI: devices can require LSB-first encodings Greg KH
2006-05-16 21:38 ` [PATCH 08/10] SPI: busnum == 0 needs to work Greg KH
2006-05-16 21:38 ` [PATCH 09/10] spi: Update to PXA2xx SPI Driver Greg KH
2005-01-01 0:10 ` Roland Dreier
2006-05-17 1:40 ` Greg KH
2006-05-16 21:38 ` [PATCH 10/10] SPI: spi_bitbang: clocking fixes Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147815518897-git-send-email-greg@kroah.com \
--to=greg@kroah.com \
--cc=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).