From: Zwane Mwaikambo <zwane@linux.realnet.co.sz>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Oops in 2.4.18 - opl3sa2 related? (typo fix)
Date: Fri, 12 Apr 2002 08:11:03 +0200 (SAST) [thread overview]
Message-ID: <Pine.LNX.4.44.0204120810280.13542-100000@netfinity.realnet.co.sz> (raw)
In-Reply-To: <Pine.LNX.4.44.0204101242520.9710-100000@netfinity.realnet.co.sz>
Slight typo...
--- linux-2.4.19/drivers/sound/opl3sa2.c.orig Tue Apr 9 13:17:21 2002
+++ linux-2.4.19/drivers/sound/opl3sa2.c Tue Apr 9 13:19:38 2002
@@ -641,7 +641,7 @@
if(!request_region(hw_config->io_base, 2, OPL3SA2_MODULE_NAME)) {
printk(KERN_ERR PFX "Control I/O port %#x not free\n",
hw_config->io_base);
- return 0;
+ goto out_nodev;
}
/*
@@ -654,7 +654,7 @@
if(tmp != misc) {
printk(KERN_ERR PFX "Control I/O port %#x is not a YMF7xx chipset!\n",
hw_config->io_base);
- return 0;
+ goto out_region;
}
/*
@@ -667,7 +667,7 @@
printk(KERN_ERR
PFX "Control I/O port %#x is not a YMF7xx chipset!\n",
hw_config->io_base);
- return 0;
+ goto out_region;
}
opl3sa2_write(hw_config->io_base, OPL3SA2_MIC, tmp);
@@ -714,9 +714,13 @@
if(opl3sa2_state[card].chipset != CHIPSET_UNKNOWN) {
/* Generate a pretty name */
opl3sa2_state[card].chipset_name = (char *)CHIPSET_TABLE[opl3sa2_state[card].chipset];
- return 1;
+ return 0;
}
- return 0;
+
+out_region:
+ release_region(hw_config->io_base, 2);
+out_nodev:
+ return -ENODEV;
}
@@ -1061,7 +1065,7 @@
opl3sa2_clear_slots(&opl3sa2_state[card].cfg_mpu);
}
- if(!probe_opl3sa2(&opl3sa2_state[card].cfg, card) ||
+ if(probe_opl3sa2(&opl3sa2_state[card].cfg, card) ||
!probe_opl3sa2_mss(&opl3sa2_state[card].cfg_mss)) {
/*
* If one or more cards are already registered, don't
--
http://function.linuxpower.ca
prev parent reply other threads:[~2002-04-12 6:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200204101027.g3AARlT27426@mail.schau.dk>
2002-04-10 10:44 ` [PATCH] Oops in 2.4.18 - opl3sa2 related? Zwane Mwaikambo
2002-04-12 6:11 ` Zwane Mwaikambo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0204120810280.13542-100000@netfinity.realnet.co.sz \
--to=zwane@linux.realnet.co.sz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).