From: Dan Streetman <ddstreet@ieee.org>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Dan Streetman <ddstreet@ieee.org>
Subject: [PATCH 1/8] crypto: nx - remove __init/__exit from VIO functions
Date: Wed, 22 Jul 2015 14:26:31 -0400 [thread overview]
Message-ID: <1437589598-23917-2-git-send-email-ddstreet@ieee.org> (raw)
In-Reply-To: <1437589598-23917-1-git-send-email-ddstreet@ieee.org>
Remove the __init and __exit modifiers from the VIO driver probe and
remove functions.
The driver functions should not be marked __init/__exit because they
can/will be called during runtime, not only at module init and exit.
Signed-off-by: Dan Streetman <ddstreet@ieee.org>
---
drivers/crypto/nx/nx-842-pseries.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842-pseries.c
index d44524d..fc59520 100644
--- a/drivers/crypto/nx/nx-842-pseries.c
+++ b/drivers/crypto/nx/nx-842-pseries.c
@@ -977,8 +977,8 @@ static struct nx842_driver nx842_pseries_driver = {
.decompress = nx842_pseries_decompress,
};
-static int __init nx842_probe(struct vio_dev *viodev,
- const struct vio_device_id *id)
+static int nx842_probe(struct vio_dev *viodev,
+ const struct vio_device_id *id)
{
struct nx842_devdata *old_devdata, *new_devdata = NULL;
unsigned long flags;
@@ -1050,7 +1050,7 @@ error:
return ret;
}
-static int __exit nx842_remove(struct vio_dev *viodev)
+static int nx842_remove(struct vio_dev *viodev)
{
struct nx842_devdata *old_devdata;
unsigned long flags;
@@ -1081,7 +1081,7 @@ static struct vio_device_id nx842_vio_driver_ids[] = {
static struct vio_driver nx842_vio_driver = {
.name = KBUILD_MODNAME,
.probe = nx842_probe,
- .remove = __exit_p(nx842_remove),
+ .remove = nx842_remove,
.get_desired_dma = nx842_get_desired_dma,
.id_table = nx842_vio_driver_ids,
};
--
2.1.0
next prev parent reply other threads:[~2015-07-22 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 18:26 [PATCH 0/8] remove 'platform' shared NX driver Dan Streetman
2015-07-22 18:26 ` Dan Streetman [this message]
2015-07-22 18:26 ` [PATCH 2/8] crypto: nx - remove pSeries NX 'status' field Dan Streetman
2015-07-22 18:26 ` [PATCH 3/8] crypto: nx - move kzalloc() out of spinlock Dan Streetman
2015-07-22 18:26 ` [PATCH 4/8] crypto: nx - don't register pSeries driver if ENODEV Dan Streetman
2015-07-22 18:26 ` [PATCH 5/8] crypto: nx - use common code for both NX decompress success cases Dan Streetman
2015-07-22 18:26 ` [PATCH 6/8] crypto: nx - merge nx-compress and nx-compress-crypto Dan Streetman
2015-07-22 18:26 ` [PATCH 7/8] crypto: nx - rename nx-842-crypto.c to nx-842.c Dan Streetman
2015-07-22 18:26 ` [PATCH 8/8] crypto: nx - make platform drivers directly register with crypto Dan Streetman
2015-07-23 10:20 ` [PATCH 0/8] remove 'platform' shared NX driver Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437589598-23917-2-git-send-email-ddstreet@ieee.org \
--to=ddstreet@ieee.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).