Staging : wilc1000: Remove unnecessary parentheses
diff mbox series

Message ID 1438147670-7590-1-git-send-email-shraddha.6596@gmail.com
State New, archived
Headers show
Series
  • Staging : wilc1000: Remove unnecessary parentheses
Related show

Commit Message

Shraddha Barke July 29, 2015, 5:27 a.m. UTC
Remove parentheses around the right hand side of an assignment
as they are not needed

The semantic patch used is :

@@
expression E;
expression f;
constant C;
@@
(
f = (E == C)
|
f =
- (
  E
- )

)

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/wilc1000/wilc_sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dan Carpenter July 29, 2015, 8:13 a.m. UTC | #1
The original code is fine...  I probably would write it the way you
suggest, but I can also see why people would write it the other way.
This isn't an official CodingStyle rule so I feel like the author gets
to choose.  Part of the reason for CodingStyle is so that we don't run
into madness of changing every single thing all the time.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio.c
index 897e47e..4b81f17 100644
--- a/drivers/staging/wilc1000/wilc_sdio.c
+++ b/drivers/staging/wilc1000/wilc_sdio.c
@@ -1072,7 +1072,7 @@  static int sdio_clear_int_ext(uint32_t val)
 						cmd.function = 0;
 						cmd.raw = 0;
 						cmd.address = 0xf8;
-						cmd.data = (1 << i);
+						cmd.data = 1 << i;
 
 						ret = g_sdio.sdio_cmd52(&cmd);
 						if (!ret) {