Staging:wilc1000 :Remove typedef from struct
diff mbox series

Message ID 1438321127-8120-1-git-send-email-shraddha.6596@gmail.com
State New, archived
Headers show
Series
  • Staging:wilc1000 :Remove typedef from struct
Related show

Commit Message

Shraddha Barke July 31, 2015, 5:38 a.m. UTC
This patch fixes the following checkpatch.pl warning:

WARNING: do not add new typedefs

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kroah-Hartman July 31, 2015, 8:52 p.m. UTC | #1
On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: do not add new typedefs
> 
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 54eb8a1..d6ef6e1 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -88,7 +88,7 @@ typedef enum {
>  } tenuFrmSubtype;
>  
>  /* Basic Frame Classes */
> -typedef enum {
> +enum {
>  	CLASS1_FRAME_TYPE      = 0x00,
>  	CLASS2_FRAME_TYPE      = 0x01,
>  	CLASS3_FRAME_TYPE      = 0x02,

Did you test-build this change?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Sudip Mukherjee Aug. 1, 2015, 4:55 a.m. UTC | #2
On Fri, Jul 31, 2015 at 01:52:13PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
> > This patch fixes the following checkpatch.pl warning:
> > 
> > WARNING: do not add new typedefs
> > 
> > Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> > ---
<snip>
> > -typedef enum {
> > +enum {
> >  	CLASS1_FRAME_TYPE      = 0x00,
> >  	CLASS2_FRAME_TYPE      = 0x01,
> >  	CLASS3_FRAME_TYPE      = 0x02,
> 
> Did you test-build this change?
This enum is not used anywhere. So did not affect the build.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Greg Kroah-Hartman Aug. 1, 2015, 3:55 p.m. UTC | #3
On Sat, Aug 01, 2015 at 10:25:26AM +0530, Sudip Mukherjee wrote:
> On Fri, Jul 31, 2015 at 01:52:13PM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
> > > This patch fixes the following checkpatch.pl warning:
> > > 
> > > WARNING: do not add new typedefs
> > > 
> > > Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> > > ---
> <snip>
> > > -typedef enum {
> > > +enum {
> > >  	CLASS1_FRAME_TYPE      = 0x00,
> > >  	CLASS2_FRAME_TYPE      = 0x01,
> > >  	CLASS3_FRAME_TYPE      = 0x02,
> > 
> > Did you test-build this change?
> This enum is not used anywhere. So did not affect the build.

Then it should be deleted :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 54eb8a1..d6ef6e1 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -88,7 +88,7 @@  typedef enum {
 } tenuFrmSubtype;
 
 /* Basic Frame Classes */
-typedef enum {
+enum {
 	CLASS1_FRAME_TYPE      = 0x00,
 	CLASS2_FRAME_TYPE      = 0x01,
 	CLASS3_FRAME_TYPE      = 0x02,