[v2,2/3] Staging: lustre: Replace comma between expression statements by a semicolon.
diff mbox series

Message ID 1438693573-5310-2-git-send-email-shraddha.6596@gmail.com
State New, archived
Headers show
Series
  • [v2,1/3] Staging: lustre: Replace comma with a semicolon
Related show

Commit Message

Shraddha Barke Aug. 4, 2015, 1:06 p.m. UTC
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:

@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v2:
  -Make subject more clearer.

 drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Julia Lawall Aug. 4, 2015, 1:34 p.m. UTC | #1
Sorry not to have been more clear.  The original subject text was OK.
Tehway to differentiate between the patches would be to put Staging:
lustre: mgc: in thi case, and Staging: lustre: libcfs: in the other one.

julia

On Tue, 4 Aug 2015, Shraddha Barke wrote:

> Replace comma between expression statements by a semicolon.
> The semantic patch used is as follows:
>
> @@
> expression e1,e2;
> @@
> e1
> - ,
> + ;
> e2;
> ---
> Changes in v2:
>   -Make subject more clearer.
>
>  drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> index 562bd95..019ee2f 100644
> --- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
> +++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> @@ -1232,7 +1232,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
>  		pos += sprintf(obdname + pos, "-%s%04x",
>  				  is_ost ? "OST" : "MDT", entry->mne_index);
>
> -		cname = is_ost ? "osc" : "mdc",
> +		cname = is_ost ? "osc" : "mdc";
>  		pos += sprintf(obdname + pos, "-%s-%s", cname, inst);
>  		lustre_cfg_bufs_reset(&bufs, obdname);
>
> --
> 2.1.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Julia Lawall Aug. 4, 2015, 1:45 p.m. UTC | #2
On Tue, 4 Aug 2015, Shraddha Barke wrote:

> Alright .
> So now I should send a version 3 right ?

Yes.

>  Was there any other issue in the way I sent this version ?

I think it's ok.

julia

Patch
diff mbox series

diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
index 562bd95..019ee2f 100644
--- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
+++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
@@ -1232,7 +1232,7 @@  static int mgc_apply_recover_logs(struct obd_device *mgc,
 		pos += sprintf(obdname + pos, "-%s%04x",
 				  is_ost ? "OST" : "MDT", entry->mne_index);
 
-		cname = is_ost ? "osc" : "mdc",
+		cname = is_ost ? "osc" : "mdc";
 		pos += sprintf(obdname + pos, "-%s-%s", cname, inst);
 		lustre_cfg_bufs_reset(&bufs, obdname);