From: Jason Wang <jasowang@redhat.com>
To: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc: kraxel@redhat.com, mst@redhat.com, Jason Wang <jasowang@redhat.com>
Subject: [PATCH] virtio-input: reset device during remove
Date: Wed, 5 Aug 2015 15:20:18 +0800 [thread overview]
Message-ID: <1438759218-30038-1-git-send-email-jasowang@redhat.com> (raw)
Spec requires a device reset during cleanup, so do it and avoid warn
in virtio core.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/virtio/virtio_input.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
index 60e2a16..6222f9b 100644
--- a/drivers/virtio/virtio_input.c
+++ b/drivers/virtio/virtio_input.c
@@ -320,6 +320,7 @@ static void virtinput_remove(struct virtio_device *vdev)
spin_unlock_irqrestore(&vi->lock, flags);
input_unregister_device(vi->idev);
+ vdev->config->reset(vdev);
vdev->config->del_vqs(vdev);
kfree(vi);
}
--
2.1.4
next reply other threads:[~2015-08-05 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 7:20 Jason Wang [this message]
2015-08-05 7:56 ` [PATCH] virtio-input: reset device during remove Michael S. Tsirkin
2015-08-05 8:18 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438759218-30038-1-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).