Fix console initialization deadlock for x86-64

Message ID 20020420183159.A22349@averell
State New, archived
Headers show
Series
  • Fix console initialization deadlock for x86-64
Related show

Commit Message

Andi Kleen April 20, 2002, 4:31 p.m. UTC
When vt_init happens to run before the keyboard is initialized (the order is random
because they're both different initcalls) then set_leds raises an not yet enabled
tasklet. This causes an endless loop on the first schedule() call because the tasklet
handling cannot handle raised but disabled tasklets.

This patch just does not do set_leds in virtual terminal initialization to avoid that.
It is done later anyways. 

Patch for 2.5.8 

-Andi


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch

diff -X ../../KDIFX -x *-o -x *-RESERVE -burpN ../../v2.5/linux/drivers/char/console.c linux/drivers/char/console.c
--- ../../v2.5/linux/drivers/char/console.c	Wed Jan 30 22:38:01 2002
+++ linux/drivers/char/console.c	Thu Apr 18 17:32:23 2002
@@ -1420,7 +1420,8 @@  static void reset_terminal(int currcons,
 	kbd_table[currcons].slockstate = 0;
 	kbd_table[currcons].ledmode = LED_SHOW_FLAGS;
 	kbd_table[currcons].ledflagstate = kbd_table[currcons].default_ledflagstate;
-	set_leds();
+	/* do not do set_leds here because this causes an endless tasklet loop
+	   when the keyboard hasn't been initialized yet */
 
 	cursor_type = CUR_DEFAULT;
 	complement_mask = s_complement_mask;