From: Dan Streetman <ddstreet@ieee.org>
To: Seth Jennings <sjennings@variantweb.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Dan Streetman <ddstreet@ieee.org>
Subject: [PATCH] zswap: move zswap_pool frequently-used fields together
Date: Tue, 18 Aug 2015 15:21:41 -0400 [thread overview]
Message-ID: <1439925701-29678-1-git-send-email-ddstreet@ieee.org> (raw)
Move the "tfm" field in struct zswap_pool to the top, after the "zpool"
field.
As suggested by Sergey Senozhatsky:
>> > ->tfm will be access pretty often, right? did you intentionally put it
>> > at the bottom offset of `struct zswap_pool'?
>>
>> no it wasn't intentional; does moving it up provide a benefit?
>
> well, I just prefer to keep 'read mostly' pointers together. all
> those cache lines, etc.
>
> gcc 5.1, x86_64
>
> struct zswap_pool {
> struct zpool *zpool;
> + struct crypto_comp * __percpu *tfm;
> struct kref kref;
> struct list_head list;
> struct rcu_head rcu_head;
> struct notifier_block notifier;
> char tfm_name[CRYPTO_MAX_ALG_NAME];
> - struct crypto_comp * __percpu *tfm;
> };
>
> ../scripts/bloat-o-meter zswap.o.old zswap.o
> add/remove: 0/0 grow/shrink: 0/6 up/down: 0/-27 (-27)
> function old new delta
> zswap_writeback_entry 659 656 -3
> zswap_frontswap_store 1445 1442 -3
> zswap_frontswap_load 417 414 -3
> zswap_pool_create 438 432 -6
> __zswap_cpu_comp_notifier.part 152 146 -6
> __zswap_cpu_comp_notifier 122 116 -6
Suggested-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Signed-off-by: Dan Streetman <ddstreet@ieee.org>
---
mm/zswap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/zswap.c b/mm/zswap.c
index b198081..4043df7 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -120,12 +120,12 @@ module_param_named(max_pool_percent, zswap_max_pool_percent, uint, 0644);
struct zswap_pool {
struct zpool *zpool;
+ struct crypto_comp * __percpu *tfm;
struct kref kref;
struct list_head list;
struct rcu_head rcu_head;
struct notifier_block notifier;
char tfm_name[CRYPTO_MAX_ALG_NAME];
- struct crypto_comp * __percpu *tfm;
};
/*
--
2.1.0
reply other threads:[~2015-08-18 19:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439925701-29678-1-git-send-email-ddstreet@ieee.org \
--to=ddstreet@ieee.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sjennings@variantweb.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).