[2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy
diff mbox series

Message ID 1441566274-3992-2-git-send-email-shraddha.6596@gmail.com
State New, archived
Headers show
Series
  • [1/3] Staging: rtl8712: Replace memcpy by ether_addr_copy
Related show

Commit Message

Shraddha Barke Sept. 6, 2015, 7:04 p.m. UTC
The patch replaces memcpy with ethr_addr_copy

The changes were applied using the following coccinelle
rule:
@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Larry Finger Sept. 6, 2015, 7:38 p.m. UTC | #1
On 09/06/2015 02:04 PM, Shraddha Barke wrote:
> The patch replaces memcpy with ethr_addr_copy
>
> The changes were applied using the following coccinelle
> rule:
> @@ expression e1, e2; @@
> - memcpy(e1, e2, ETH_ALEN);
> + ether_addr_copy(e1, e2);
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>   drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

The same comments apply as in patch 1/3. NACK.

Larry

>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> index 86f52ac..cf243fe 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> @@ -122,8 +122,8 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,
>
>   		eth_zero_addr(wrqu->ap_addr.sa_data);
>   	else
> -		memcpy(wrqu->ap_addr.sa_data,
> -		       ieee->current_network.bssid, ETH_ALEN);
> +		ether_addr_copy(wrqu->ap_addr.sa_data,
> +				ieee->current_network.bssid);
>
>   	spin_unlock_irqrestore(&ieee->lock, flags);
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
index 86f52ac..cf243fe 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
@@ -122,8 +122,8 @@  int rtllib_wx_get_wap(struct rtllib_device *ieee,
 
 		eth_zero_addr(wrqu->ap_addr.sa_data);
 	else
-		memcpy(wrqu->ap_addr.sa_data,
-		       ieee->current_network.bssid, ETH_ALEN);
+		ether_addr_copy(wrqu->ap_addr.sa_data,
+				ieee->current_network.bssid);
 
 	spin_unlock_irqrestore(&ieee->lock, flags);