[3/3] Staging: rtl8192u: r8192U_core.c: Replace memcpy with eth_addr_copy
diff mbox series

Message ID 1441566274-3992-3-git-send-email-shraddha.6596@gmail.com
State New, archived
Headers show
Series
  • [1/3] Staging: rtl8712: Replace memcpy by ether_addr_copy
Related show

Commit Message

Shraddha Barke Sept. 6, 2015, 7:04 p.m. UTC
This patch replaces memcpy with eth_addr_copy

The changes were applied using the following coccinelle
rule:
@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/rtl8192u/r8192U_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Larry Finger Sept. 6, 2015, 7:39 p.m. UTC | #1
On 09/06/2015 02:04 PM, Shraddha Barke wrote:
> This patch replaces memcpy with eth_addr_copy
>
> The changes were applied using the following coccinelle
> rule:
> @@ expression e1, e2; @@
> - memcpy(e1, e2, ETH_ALEN);
> + ether_addr_copy(e1, e2);
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>   drivers/staging/rtl8192u/r8192U_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 6f6fe38..577d3a4 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -3430,7 +3430,7 @@ static int r8192_set_mac_adr(struct net_device *dev, void *mac)
>
>   	down(&priv->wx_sem);
>
> -	memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
> +	ether_addr_copy(dev->dev_addr, addr->sa_data);
>
>   	schedule_work(&priv->reset_wq);
>   	up(&priv->wx_sem);
>

This patch has the same problems as do both patches 1 and 2.

NACK.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 6f6fe38..577d3a4 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -3430,7 +3430,7 @@  static int r8192_set_mac_adr(struct net_device *dev, void *mac)
 
 	down(&priv->wx_sem);
 
-	memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+	ether_addr_copy(dev->dev_addr, addr->sa_data);
 
 	schedule_work(&priv->reset_wq);
 	up(&priv->wx_sem);