linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	"James E.J. Bottomley" <JBottomley@odin.com>
Cc: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
	dgibson@redhat.com, thuth@redhat.com, pbonzini@redhat.com,
	lvivier@redhat.com
Subject: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.
Date: Thu, 10 Sep 2015 11:23:13 +0200	[thread overview]
Message-ID: <1441876994-16821-2-git-send-email-lvivier@redhat.com> (raw)
In-Reply-To: <1441876994-16821-1-git-send-email-lvivier@redhat.com>

As devices with values greater than that are silently ignored,
this gives some hints to the sys admin to know why he doesn't see
his devices...

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 3e76490..f9d7ec4 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -106,9 +106,9 @@ MODULE_LICENSE("GPL");
 MODULE_VERSION(IBMVSCSI_VERSION);
 
 module_param_named(max_id, max_id, int, S_IRUGO);
-MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
+MODULE_PARM_DESC(max_id, "Largest ID value for each channel [Default=64]");
 module_param_named(max_channel, max_channel, int, S_IRUGO);
-MODULE_PARM_DESC(max_channel, "Largest channel value");
+MODULE_PARM_DESC(max_channel, "Largest channel value [Default=3]");
 module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
 module_param_named(max_requests, max_requests, int, S_IRUGO);
@@ -2294,6 +2294,10 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
 	host->max_channel = max_channel;
 	host->max_cmd_len = 16;
 
+	dev_info(dev,
+		 "Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n",
+		 host->max_id, host->max_lun, host->max_channel);
+
 	if (scsi_add_host(hostdata->host, hostdata->dev))
 		goto add_host_failed;
 
-- 
2.1.0


  reply	other threads:[~2015-09-10  9:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10  9:23 [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
2015-09-10  9:23 ` Laurent Vivier [this message]
2015-09-11  0:53   ` [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel David Gibson
2015-09-24 16:16   ` Laurent Vivier
2015-09-24 17:29   ` Brian King
2015-09-28 21:39   ` Tyrel Datwyler
2015-09-10  9:23 ` [PATCH 3/3] ibmvsci: Allow to configure maximum LUN Laurent Vivier
2015-09-11  0:54   ` David Gibson
2015-09-24 16:16   ` Laurent Vivier
2015-09-24 17:38   ` Brian King
2015-09-28 21:39   ` Tyrel Datwyler
2015-09-11  0:52 ` [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only David Gibson
2015-09-24 16:15 ` Laurent Vivier
2015-09-24 17:28 ` Brian King
2015-09-28 21:38 ` Tyrel Datwyler
2015-10-13 21:23 ` Laurent Vivier
2015-10-27 15:38   ` Laurent Vivier
2015-11-03  5:00     ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441876994-16821-2-git-send-email-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=JBottomley@odin.com \
    --cc=dgibson@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    --cc=tyreld@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).