From: Shraddha Barke <shraddha.6596@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, Shraddha Barke <shraddha.6596@gmail.com>
Subject: [PATCH v2 06/16] Staging: rtl8188eu: Remove explicit NULL comparison
Date: Fri, 11 Sep 2015 10:40:53 +0530 [thread overview]
Message-ID: <1441948259-3380-2-git-send-email-shraddha.6596@gmail.com> (raw)
In-Reply-To: <1441948259-3380-1-git-send-email-shraddha.6596@gmail.com>
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Change in v2-
No change.
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
index 0a62bfa..d528140 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
@@ -467,7 +467,7 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, bool bDLFinished)
DBG_88E("%s\n", __func__);
ReservedPagePacket = kzalloc(1000, GFP_KERNEL);
- if (ReservedPagePacket == NULL) {
+ if (!ReservedPagePacket) {
DBG_88E("%s: alloc ReservedPagePacket fail!\n", __func__);
return;
}
@@ -537,7 +537,7 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, bool bDLFinished)
TotalPacketLen = BufIndex + QosNullLength;
pmgntframe = alloc_mgtxmitframe(pxmitpriv);
- if (pmgntframe == NULL)
+ if (!pmgntframe)
goto exit;
/* update attribute */
--
2.1.4
next prev parent reply other threads:[~2015-09-11 5:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 5:10 [PATCH v2 05/16] Staging: rtl8188eu: core: Remove explicit NULL comparison Shraddha Barke
2015-09-11 5:10 ` Shraddha Barke [this message]
2015-09-11 5:10 ` [PATCH v2 11/16] Staging: rtl8188eu: hal: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 12/16] Staging: rtl8188eu: hal: Hal8188ERateAdaptive.c: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 13/16] Staging: rtl8188eu: hal: rtl8188eu_xmit.c: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 14/16] Staging: rtl8188eu: os_dep: recv_linux.c: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 15/16] Staging: rtl8188eu: os_dep: mlme_linux.c: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 16/16] Staging: rtl8188eu: os_dep: osdep_service.c: " Shraddha Barke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441948259-3380-2-git-send-email-shraddha.6596@gmail.com \
--to=shraddha.6596@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=andrzejtp2010@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).