[4/4] Staging: vt6656: Bool tests don't need comparisons
diff mbox series

Message ID 1442037000-2953-4-git-send-email-shraddha.6596@gmail.com
State New, archived
Headers show
Series
  • [1/4] Staging: rtl8723au: Bool tests don't need comparisons
Related show

Commit Message

Shraddha Barke Sept. 12, 2015, 5:50 a.m. UTC
This patch removes comparisons to true/false values on bool variables.
Fix made using Coccinelle

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/vt6656/wcmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Julia Lawall Sept. 12, 2015, 6:10 a.m. UTC | #1
On Sat, 12 Sep 2015, Shraddha Barke wrote:

> This patch removes comparisons to true/false values on bool variables.
> Fix made using Coccinelle
> 
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>  drivers/staging/vt6656/wcmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
> index 3cbf479..ab7401e 100644
> --- a/drivers/staging/vt6656/wcmd.c
> +++ b/drivers/staging/vt6656/wcmd.c
> @@ -177,7 +177,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum vnt_cmd command)
>  	ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE);
>  	priv->free_cmd_queue--;
>  
> -	if (priv->cmd_running == false)
> +	if (priv->cmd_running)

You turned it into a test for true.  It seems strange that this would 
happen if you used a rule.

julia

>  		vnt_cmd_complete(priv);
>  
>  	return true;
> -- 
> 2.1.4
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
index 3cbf479..ab7401e 100644
--- a/drivers/staging/vt6656/wcmd.c
+++ b/drivers/staging/vt6656/wcmd.c
@@ -177,7 +177,7 @@  int vnt_schedule_command(struct vnt_private *priv, enum vnt_cmd command)
 	ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE);
 	priv->free_cmd_queue--;
 
-	if (priv->cmd_running == false)
+	if (priv->cmd_running)
 		vnt_cmd_complete(priv);
 
 	return true;