From: Laurent Vivier <lvivier@redhat.com>
To: martin.petersen@oracle.com
Cc: brking@linux.vnet.ibm.com, tyreld@linux.vnet.ibm.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
lvivier@redhat.com
Subject: [PATCH v2 1/3] ibmvscsi: make parameters max_id and max_channel read-only
Date: Wed, 4 Nov 2015 11:20:49 +0100 [thread overview]
Message-ID: <1446632451-22365-2-git-send-email-lvivier@redhat.com> (raw)
In-Reply-To: <1446632451-22365-1-git-send-email-lvivier@redhat.com>
The value of the parameter is never re-read by the driver,
so a new value is ignored. Let know the user he
can't modify it by removing writable attribute.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 6a41c36..3e76490 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
MODULE_LICENSE("GPL");
MODULE_VERSION(IBMVSCSI_VERSION);
-module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
+module_param_named(max_id, max_id, int, S_IRUGO);
MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
-module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
+module_param_named(max_channel, max_channel, int, S_IRUGO);
MODULE_PARM_DESC(max_channel, "Largest channel value");
module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
--
2.1.0
next prev parent reply other threads:[~2015-11-04 10:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 10:20 [PATCH v2 0/3] ibmvscsi parameter cleanup Laurent Vivier
2015-11-04 10:20 ` Laurent Vivier [this message]
2015-11-04 10:20 ` [PATCH v2 2/3] ibmvscsi: display default value for max_id, max_lun and max_channel Laurent Vivier
2015-11-04 10:20 ` [PATCH v2 3/3] ibmvscsi: Allow to configure maximum LUN Laurent Vivier
2015-11-04 10:24 ` Laurent Vivier
2015-11-04 11:16 ` Hannes Reinecke
2015-11-04 11:46 ` Laurent Vivier
2015-11-04 13:02 ` Hannes Reinecke
2015-11-04 23:06 ` Brian King
2015-11-05 8:26 ` Laurent Vivier
2015-11-05 20:00 ` Brian King
2015-11-05 8:51 ` Hannes Reinecke
2015-11-05 19:01 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446632451-22365-2-git-send-email-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).