linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Dave Chinner <david@fromorbit.com>,
	linux-ext4@vger.kernel.org, xfs@oss.sgi.com,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-api@vger.kernel.org
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Subject: [PATCH v14 10/22] posix_acl: Unexport acl_by_type and make it static
Date: Thu,  5 Nov 2015 12:39:28 +0100	[thread overview]
Message-ID: <1446723580-3747-11-git-send-email-agruenba@redhat.com> (raw)
In-Reply-To: <1446723580-3747-1-git-send-email-agruenba@redhat.com>

acl_by_type(inode, type) returns a pointer to either inode->i_acl or
inode->i_default_acl depending on type.  This is useful in
fs/posix_acl.c, but should never have been visible outside that file.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 fs/posix_acl.c            | 3 +--
 include/linux/posix_acl.h | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/posix_acl.c b/fs/posix_acl.c
index 4fb17de..aacfb58 100644
--- a/fs/posix_acl.c
+++ b/fs/posix_acl.c
@@ -21,7 +21,7 @@
 #include <linux/export.h>
 #include <linux/user_namespace.h>
 
-struct posix_acl **acl_by_type(struct inode *inode, int type)
+static struct posix_acl **acl_by_type(struct inode *inode, int type)
 {
 	switch (type) {
 	case ACL_TYPE_ACCESS:
@@ -32,7 +32,6 @@ struct posix_acl **acl_by_type(struct inode *inode, int type)
 		BUG();
 	}
 }
-EXPORT_SYMBOL(acl_by_type);
 
 struct posix_acl *get_cached_acl(struct inode *inode, int type)
 {
diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h
index 3e96a6a..5b5a80c 100644
--- a/include/linux/posix_acl.h
+++ b/include/linux/posix_acl.h
@@ -99,7 +99,6 @@ extern int posix_acl_create(struct inode *, umode_t *, struct posix_acl **,
 extern int simple_set_acl(struct inode *, struct posix_acl *, int);
 extern int simple_acl_create(struct inode *, struct inode *);
 
-struct posix_acl **acl_by_type(struct inode *inode, int type);
 struct posix_acl *get_cached_acl(struct inode *inode, int type);
 struct posix_acl *get_cached_acl_rcu(struct inode *inode, int type);
 void set_cached_acl(struct inode *inode, int type, struct posix_acl *acl);
-- 
2.5.0


  parent reply	other threads:[~2015-11-05 11:41 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 11:39 [PATCH v14 00/22] Richacls (Core and Ext4) Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 01/22] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher
2015-11-06 20:40   ` Andreas Dilger
2015-11-05 11:39 ` [PATCH v14 02/22] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher
2015-11-06 20:58   ` Andreas Dilger
2015-11-07 17:44     ` Andreas Gruenbacher
2015-11-08  8:18       ` Andreas Dilger
2015-11-05 11:39 ` [PATCH v14 03/22] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD " Andreas Gruenbacher
2015-11-06 21:26   ` Andreas Dilger
2015-11-07 20:47     ` Andreas Gruenbacher
2015-11-06 21:26   ` Andreas Dilger
2015-11-05 11:39 ` [PATCH v14 04/22] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher
2015-11-06 21:04   ` Andreas Dilger
2015-11-05 11:39 ` [PATCH v14 05/22] vfs: Add permission flags for setting file attributes Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 06/22] richacl: In-memory representation and helper functions Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 07/22] richacl: Permission mapping functions Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 08/22] richacl: Compute maximum file masks from an acl Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 09/22] richacl: Permission check algorithm Andreas Gruenbacher
2015-11-05 11:39 ` Andreas Gruenbacher [this message]
2015-11-05 11:39 ` [PATCH v14 11/22] vfs: Cache base_acl objects in inodes Andreas Gruenbacher
2015-11-08  8:06   ` Andreas Dilger
2015-11-05 11:39 ` [PATCH v14 12/22] vfs: Add get_richacl and set_richacl inode operations Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 13/22] vfs: Cache richacl in struct inode Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 14/22] richacl: Update the file masks in chmod() Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 15/22] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 16/22] richacl: Create-time inheritance Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 17/22] richacl: Automatic Inheritance Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 18/22] richacl: xattr mapping functions Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 19/22] richacl: Add richacl xattr handler Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 20/22] vfs: Add richacl permission checking Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 21/22] ext4: Add richacl support Andreas Gruenbacher
2015-11-05 11:39 ` [PATCH v14 22/22] ext4: Add richacl feature flag Andreas Gruenbacher
2015-11-08  8:12   ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446723580-3747-11-git-send-email-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=david@fromorbit.com \
    --cc=jlayton@poochiereds.net \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).