From: Laurent Vivier <lvivier@redhat.com>
To: martin.petersen@oracle.com
Cc: hare@suse.de, brking@linux.vnet.ibm.com,
tyreld@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, lvivier@redhat.com
Subject: [PATCH v3 3/3] ibmvscsi: Allow to configure maximum LUN
Date: Mon, 9 Nov 2015 14:53:52 +0100 [thread overview]
Message-ID: <1447077232-5335-4-git-send-email-lvivier@redhat.com> (raw)
In-Reply-To: <1447077232-5335-1-git-send-email-lvivier@redhat.com>
QEMU allows until 32 LUNs.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 9 ++++++++-
drivers/scsi/ibmvscsi/ibmvscsi.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 04de287..56a9a28 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -84,6 +84,7 @@
*/
static int max_id = 64;
static int max_channel = 3;
+static int max_lun = 8;
static int init_timeout = 300;
static int login_timeout = 60;
static int info_timeout = 30;
@@ -117,6 +118,9 @@ module_param_named(fast_fail, fast_fail, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(fast_fail, "Enable fast fail. [Default=1]");
module_param_named(client_reserve, client_reserve, int, S_IRUGO );
MODULE_PARM_DESC(client_reserve, "Attempt client managed reserve/release");
+module_param(max_lun, int, S_IRUGO);
+MODULE_PARM_DESC(max_lun, "Maximum LUN value "
+ "[Default=8,Max="__stringify(IBMVSCSI_MAX_LUN)"]");
static void ibmvscsi_handle_crq(struct viosrp_crq *crq,
struct ibmvscsi_host_data *hostdata);
@@ -2289,7 +2293,7 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
goto init_pool_failed;
}
- host->max_lun = 8;
+ host->max_lun = max_lun;
host->max_id = max_id;
host->max_channel = max_channel;
host->max_cmd_len = 16;
@@ -2414,6 +2418,9 @@ int __init ibmvscsi_module_init(void)
{
int ret;
+ if (max_lun > IBMVSCSI_MAX_LUN)
+ return -EINVAL;
+
/* Ensure we have two requests to do error recovery */
driver_template.can_queue = max_requests;
max_events = max_requests + 2;
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.h b/drivers/scsi/ibmvscsi/ibmvscsi.h
index 7d64867..12141fb 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.h
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.h
@@ -48,6 +48,7 @@ struct Scsi_Host;
#define IBMVSCSI_CMDS_PER_LUN_DEFAULT 16
#define IBMVSCSI_MAX_SECTORS_DEFAULT 256 /* 32 * 8 = default max I/O 32 pages */
#define IBMVSCSI_MAX_CMDS_PER_LUN 64
+#define IBMVSCSI_MAX_LUN 31
/* ------------------------------------------------------------
* Data Structures
--
2.1.0
next prev parent reply other threads:[~2015-11-09 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 13:53 [PATCH v3 0/3] ibmvscsi parameter cleanup Laurent Vivier
2015-11-09 13:53 ` [PATCH v3 1/3] ibmvscsi: make parameters max_id and max_channel read-only Laurent Vivier
2015-11-09 13:53 ` [PATCH v3 2/3] ibmvscsi: display default value for max_id, max_lun and max_channel Laurent Vivier
2015-11-09 13:53 ` Laurent Vivier [this message]
2015-11-09 14:04 ` [PATCH v3 3/3] ibmvscsi: Allow to configure maximum LUN Hannes Reinecke
2015-11-09 14:26 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447077232-5335-4-git-send-email-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=brking@linux.vnet.ibm.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).