From: Diego Viola <diego.viola@gmail.com>
To: cooldavid@cooldavid.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
richard.weinberger@gmail.com, pavel@ucw.cz, rjw@rjwysocki.net,
davem@davemloft.net, valdis.kletnieks@vt.edu,
Diego Viola <diego.viola@gmail.com>
Subject: [PATCH v3] net: jme: fix suspend/resume on JMC260
Date: Tue, 23 Feb 2016 12:04:04 -0300 [thread overview]
Message-ID: <1456239844-4109-1-git-send-email-diego.viola@gmail.com> (raw)
The JMC260 network card fails to suspend/resume because the call to
jme_start_irq() was too early, moving the call to jme_start_irq() after
the call to jme_reset_link() makes it work.
Prior this change suspend/resume would fail unless /sys/power/pm_async=0
was explicitly specified.
Relevant bug report: https://bugzilla.kernel.org/show_bug.cgi?id=112351
Signed-off-by: Diego Viola <diego.viola@gmail.com>
---
drivers/net/ethernet/jme.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index b1de7af..8adbe8f 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -3312,13 +3312,14 @@ jme_resume(struct device *dev)
jme_reset_phy_processor(jme);
jme_phy_calibration(jme);
jme_phy_setEA(jme);
- jme_start_irq(jme);
netif_device_attach(netdev);
atomic_inc(&jme->link_changing);
jme_reset_link(jme);
+ jme_start_irq(jme);
+
return 0;
}
--
2.7.1
next reply other threads:[~2016-02-23 15:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 15:04 Diego Viola [this message]
2016-02-23 16:34 ` [PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola
2016-02-25 0:43 ` Diego Viola
2016-02-25 4:58 ` David Miller
2016-02-25 15:38 ` Diego Viola
2016-03-02 5:14 ` Guo-Fu Tseng
2016-03-03 3:19 ` Diego Viola
2016-03-03 5:55 ` Diego Viola
2016-03-03 21:14 ` Diego Viola
2016-03-03 21:19 ` Diego Viola
2016-03-04 4:32 ` Diego Viola
2016-03-05 2:26 ` Diego Viola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456239844-4109-1-git-send-email-diego.viola@gmail.com \
--to=diego.viola@gmail.com \
--cc=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=richard.weinberger@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).