From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Subject: [PATCH 3/5] leds: trigger: panic: Use led_trigger_event_nosleep
Date: Mon, 4 Apr 2016 17:22:04 -0300 [thread overview]
Message-ID: <1459801326-5541-4-git-send-email-ezequiel@vanguardiasur.com.ar> (raw)
In-Reply-To: <1459801326-5541-1-git-send-email-ezequiel@vanguardiasur.com.ar>
Calling led_trigger_event may schedule a delayed LED set,
if the LED was being used by a delayed blink trigger when
the kernel paniced.
Therefore, we must use led_trigger_event_nosleep to override
this situation, and set the LED unconditionally.
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
---
drivers/leds/trigger/ledtrig-panic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/trigger/ledtrig-panic.c b/drivers/leds/trigger/ledtrig-panic.c
index 627b350c5ec3..145c238d55f2 100644
--- a/drivers/leds/trigger/ledtrig-panic.c
+++ b/drivers/leds/trigger/ledtrig-panic.c
@@ -17,7 +17,7 @@ static struct led_trigger *trigger;
static long led_panic_blink(int state)
{
- led_trigger_event(trigger, state ? LED_FULL : LED_OFF);
+ led_trigger_event_nosleep(trigger, state ? LED_FULL : LED_OFF);
return 0;
}
--
2.7.0
next prev parent reply other threads:[~2016-04-04 20:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 20:22 [PATCH 0/5] Extend the LED panic trigger Ezequiel Garcia
2016-04-04 20:22 ` [PATCH 1/5] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic Ezequiel Garcia
2016-04-05 21:36 ` Jacek Anaszewski
2016-04-24 9:25 ` Pavel Machek
2016-04-24 9:29 ` Pavel Machek
2016-04-25 6:56 ` Jacek Anaszewski
2016-04-25 16:27 ` Ezequiel Garcia
2016-04-26 7:15 ` Jacek Anaszewski
2016-04-27 20:10 ` Ezequiel Garcia
2016-05-02 7:06 ` Pavel Machek
2016-04-04 20:22 ` [PATCH 2/5] leds: triggers: Add a led_trigger_event_nosleep API Ezequiel Garcia
2016-04-05 21:36 ` Jacek Anaszewski
2016-04-06 4:38 ` Ezequiel Garcia
2016-04-06 6:12 ` Jacek Anaszewski
2016-04-04 20:22 ` Ezequiel Garcia [this message]
2016-04-04 20:22 ` [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Ezequiel Garcia
2016-04-05 21:37 ` Jacek Anaszewski
2016-04-06 4:39 ` Ezequiel Garcia
2016-04-06 15:12 ` Rob Herring
2016-04-06 16:13 ` Ezequiel Garcia
2016-04-04 20:22 ` [PATCH 5/5] leds: gpio: Support the panic-blink firmware property Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459801326-5541-4-git-send-email-ezequiel@vanguardiasur.com.ar \
--to=ezequiel@vanguardiasur.com.ar \
--cc=j.anaszewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).