From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>,
Nick Piggin <npiggin@suse.de>,
Linux Memory Management <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [patch 5/6] generic_file_buffered_write(): max_len cleanup
Date: Tue, 10 Oct 2006 23:18:05 -0700 [thread overview]
Message-ID: <20061010231805.3517f5e1.akpm@osdl.org> (raw)
In-Reply-To: <20061010231424.db88931f.akpm@osdl.org>
From: Andrew Morton <akpm@osdl.org>
More dirty code.
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
mm/filemap.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff -puN mm/filemap.c~generic_file_buffered_write-max_len-cleanup mm/filemap.c
--- a/mm/filemap.c~generic_file_buffered_write-max_len-cleanup
+++ a/mm/filemap.c
@@ -2090,7 +2090,6 @@ generic_file_buffered_write(struct kiocb
do {
pgoff_t index; /* Pagecache index for current page */
unsigned long offset; /* Offset into pagecache page */
- unsigned long maxlen; /* Bytes remaining in current iovec */
size_t bytes; /* Bytes to write to page */
size_t copied; /* Bytes copied from user */
@@ -2100,9 +2099,7 @@ generic_file_buffered_write(struct kiocb
if (bytes > count)
bytes = count;
- maxlen = cur_iov->iov_len - iov_offset;
- if (maxlen > bytes)
- maxlen = bytes;
+ bytes = min(cur_iov->iov_len - iov_offset, bytes);
/*
* Bring in the user page that we will copy from _first_.
_
next prev parent reply other threads:[~2006-10-11 6:18 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 14:21 [rfc] 2.6.19-rc1-git5: consolidation of file backed fault handlers Nick Piggin
2006-10-10 14:21 ` [patch 1/5] mm: fault vs invalidate/truncate check Nick Piggin
2006-10-10 14:21 ` [patch 2/5] mm: fault vs invalidate/truncate race fix Nick Piggin
2006-10-11 4:38 ` Andrew Morton
2006-10-11 5:39 ` Nick Piggin
2006-10-11 6:00 ` Andrew Morton
2006-10-11 9:21 ` Nick Piggin
2006-10-11 16:21 ` Linus Torvalds
2006-10-11 16:57 ` SPAM: " Nick Piggin
2006-10-11 17:11 ` Linus Torvalds
2006-10-11 17:21 ` SPAM: " Nick Piggin
2006-10-11 17:38 ` Linus Torvalds
2006-10-12 3:33 ` Nick Piggin
2006-10-12 15:37 ` Linus Torvalds
2006-10-12 15:40 ` Nick Piggin
2006-10-11 5:13 ` Andrew Morton
2006-10-11 5:50 ` Nick Piggin
2006-10-11 6:10 ` Andrew Morton
2006-10-11 6:17 ` [patch 1/6] revert "generic_file_buffered_write(): handle zero length iovec segments" Andrew Morton
[not found] ` <20061010231150.fb9e30f5.akpm@osdl.org>
2006-10-11 6:17 ` [patch 2/6] revert "generic_file_buffered_write(): deadlock on vectored write" Andrew Morton
[not found] ` <20061010231243.bc8b834c.akpm@osdl.org>
2006-10-11 6:17 ` [patch 3/6] generic_file_buffered_write() cleanup Andrew Morton
[not found] ` <20061010231339.a79c1fae.akpm@osdl.org>
2006-10-11 6:18 ` [patch 4/6] generic_file_buffered_write(): fix page prefaulting Andrew Morton
[not found] ` <20061010231424.db88931f.akpm@osdl.org>
2006-10-11 6:18 ` Andrew Morton [this message]
[not found] ` <20061010231514.c1da7355.akpm@osdl.org>
2006-10-11 6:18 ` [patch 6/6] fix pagecache write deadlocks Andrew Morton
2006-10-21 1:53 ` [patch 2/5] mm: fault vs invalidate/truncate race fix Benjamin Herrenschmidt
2006-10-10 14:22 ` [patch 3/5] mm: fault handler to replace nopage and populate Nick Piggin
2006-10-10 14:22 ` [patch 4/5] mm: add vm_insert_pfn helpler Nick Piggin
2006-10-11 10:12 ` Thomas Hellstrom
2006-10-11 11:24 ` Nick Piggin
2006-10-11 21:30 ` Thomas Hellström
2006-10-10 14:22 ` [patch 5/5] mm: merge nopfn with fault handler Nick Piggin
2006-10-10 14:26 ` [rfc] 2.6.19-rc1-git5: consolidation of file backed fault handlers Nick Piggin
2006-10-10 14:33 ` Christoph Hellwig
2006-10-10 15:01 ` Nick Piggin
2006-10-10 16:09 ` Arjan van de Ven
2006-10-11 0:46 ` SPAM: " Nick Piggin
2006-10-10 15:07 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010231805.3517f5e1.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).